Fix regressions from stderr/stdout changes #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnf5-automatic tests expect these error messages on stderr rather than in the dnf5-automatic output. Not all of these error messages can be moved, e.g. the "Error: reboot command returned nonzero exit code" message. dnf5-automatic output is emitted before the reboot command is called, so there would be no way to capture and report that error message.
Merged
via the queue into
rpm-software-management:main
with commit Sep 6, 2024
2706e64
12 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1641, I forgot to push these two commits.
More details in the commit messages.
Fixes the following ci-dnf-stack tests:
dnf/install-file-conflicts.feature:8 An error is reported when a package with a file conflict is tried to be installeddnf/dnf-automatic/reboot.feature:95 dnf-automatic shows error message when reboot command failed