Change gpgcheck option to pkg_gpgcheck but stay compatible
#1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the name to a more apt `pkg_gpgcheck` but `gpgcheck` is still accepted. At this point I am not sure we will ever be able to drop it. It adds new getter API to both main and repo: `get_pkg_gpgcheck_option` and depracates the old `get_gpgcheck_option`. It also extends `libdnf5::cli::output::IRepoInfo` with `get_pkg_gpgcheck` and the `dnf5daemon-server` should also accept `pkg_gpgcheck` attribute. For: rpm-software-management#1649
kontura
added a commit
to kontura/ci-dnf-stack
that referenced
this pull request
Oct 9, 2024
kontura
commented
Oct 9, 2024
jan-kolarik
reviewed
Oct 15, 2024
jan-kolarik
approved these changes
Oct 21, 2024
|
Thanks! |
Merged
via the queue into
rpm-software-management:main
with commit Oct 21, 2024
03fa953
14 of 20 checks passed
jan-kolarik
pushed a commit
to rpm-software-management/ci-dnf-stack
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the name to a more apt
pkg_gpgcheckbutgpgcheckis still accepted. At this point I am not sure we will ever be able to drop it.It adds new getter API to both main and repo:
get_pkg_gpgcheck_optionand depracates the oldget_gpgcheck_option.It also extends
libdnf5::cli::output::IRepoInfowithget_pkg_gpgcheckand thednf5daemon-servershould also acceptpkg_gpgcheckattribute.For: #1649