Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Drop errorlevel config option" #1793

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Revert "Drop errorlevel config option" #1793

merged 1 commit into from
Oct 23, 2024

Conversation

kontura
Copy link
Contributor

@kontura kontura commented Oct 22, 2024 •
edited
Loading

Keep the defunct options to preserve API.

Revert: #1788

It keeps the docs update.

@kontura kontura mentioned this pull request Oct 22, 2024
Merged
@ppisar ppisar self-assigned this Oct 22, 2024
ppisar
ppisar reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@ppisar ppisar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend renaming this commit to "Return ConfigMain::get_errorlevel_option API". Otherwise it could evoke that you reverts the whole commit.

include/libdnf5/conf/config_main.hpp Outdated Show resolved Hide resolved
libdnf5/conf/config_main.cpp Show resolved Hide resolved
@kontura kontura force-pushed the revert_drop branch 2 times, most recently from 0518f06 to 8d74a48 Compare October 22, 2024 12:15
@kontura
Copy link
Contributor Author

kontura commented Oct 22, 2024

The required formatting seems a bit odd but I have updated it.

I have also renamed the commit. 👍

ppisar
ppisar approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@ppisar ppisar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good.

I compared list of symbols and there is no change comparing to a commit before cc8a0f9.

I also verified that using the get_errorlevel_option() method emits a warning.

The rawhide failures (duplicate --ruby option) are unrelated (#1794).

@ppisar ppisar added this pull request to the merge queue Oct 23, 2024
Merged via the queue into rpm-software-management:main with commit 1a57764 Oct 23, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisar ppisar ppisar approved these changes

Assignees

@ppisar ppisar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kontura @ppisar