build: Remove an explicit swig option -ruby #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building Ruby binding with Swig 4.3.0 failed:
cd /home/test/dnf5/redhat-linux-build/bindings/ruby/libdnf5 && /usr/bin/cmake -E env SWIG_LIB=/usr/share/swig/4.3.0 /usr/bin/swig -ruby -DSWIGWORDSIZE64 -module advisory -ruby -outdir /home/test/dnf5/redhat-linux-build/bindings/ruby/libdnf5 -c++ -module advisory -I/home/test/dnf5/include -I/home/test/dnf5/common -I/usr/include -o /home/test/dnf5/redhat-linux-build/bindings/ruby/libdnf5/CMakeFiles/ruby_advisory.dir/advisoryRUBY_wrap.cxx /home/test/dnf5/bindings/libdnf5/advisory.i
Only one target language can be supported at a time (both -ruby and -ruby were specified).
The cause was an explicit and unnecessary "-ruby" option in
CMAKE_SWIG_FLAGS.
This patch removes it. The targetted langauge is already set with
swig_add_library().
Resolves: rpm-software-management#1794
Merged
via the queue into
rpm-software-management:main
with commit Oct 23, 2024
0dc0063
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building Ruby binding with Swig 4.3.0 failed:
The cause was an explcitit and unnecessary "-ruby" option in CMAKE_SWIG_FLAGS.
This patch removes it. The targetted langauge is already set with swig_add_library().
Resolves: #1794