-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a bunch of repoquery options #573
Add a bunch of repoquery options #573
Conversation
@@ -256,6 +256,16 @@ void RepoqueryCommand::set_argument_parser() { | |||
"Limit to unneeded installed packages (i.e. packages that were installed as " | |||
"dependencies but are no longer needed).", | |||
false); | |||
extras = std::make_unique<libdnf::cli::session::BoolOption>( | |||
*this, "extras", '\0', "Limit to packages that are not present in any of of available repositories.", false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should be more explicit here and state that the packages are installed - Limit to installed packages...
. Does it make the description too long?
And there is a duplicated of - ...in any of of available...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, I have also rephrased the ending a bit.
"Limit to packages that provide an upgrade for some already installed package.", | ||
false); | ||
recent = std::make_unique<libdnf::cli::session::BoolOption>( | ||
*this, "recent", '\0', "Limit to only recently edited packages.", false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's also in dnf4 docs, but I consider word edited
a bit odd in this context. Wouldn't be changed
or added
a better fit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
seems a bit misleading to me but changed
is better, thanks. 👍
Please, add the new options also to |
In order to see whether commandline pkgs need to be loaded we need to know if available repos are needed. This requires that `configure()` is called before `load_additional_packages()` but this was true even before because it relyad on `only_system_repo_needed` being set.
It also renames `only_system_repo_needed` to a more appropriate system_repo_needed`.
Right, all of the new options are missing the docs I was thinking I will add it all at once in a separate PR if that is ok? |
Thanks, separate PR for docs is fine. |
Add several repoquery options.
For: #122