Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpgcheck security and usability fixes #697

Merged
merged 5 commits into from
Jul 31, 2023
Merged

gpgcheck security and usability fixes #697

merged 5 commits into from
Jul 31, 2023

Commits on Jul 24, 2023

  1. Don't allow main gpgcheck=0 to override repo config 

    The main gpgcheck option should not override the per-repo setting. The
repo gpgcheck option is a child of the main gpgcheck option, so setting
the main gpgcheck option will still work, but we want the repo gpgcheck
option to have a higher priority.

The repo-specific gpgcheck option is checked by RpmSignature::check_package_signature.

Resolves one of the problems described in rpm-software-management#617.
    @evan-goode
    evan-goode committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    77146c2 View commit details
    Browse the repository at this point in the history

  2. Display warning message when any PGP checks skipped

    @evan-goode
    evan-goode committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    ba557d3 View commit details
    Browse the repository at this point in the history

  3. Abort PGP checking immediately if any checks fail

    @evan-goode
    evan-goode committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    09ab532 View commit details
    Browse the repository at this point in the history

  4. Include RPM logs in KeyImportError

    @evan-goode
    evan-goode committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    0b8eba0 View commit details
    Browse the repository at this point in the history

  5. gpgcheck: fix unit tests after adding warning and SKIPPED

    @evan-goode
    evan-goode committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    a1a0331 View commit details
    Browse the repository at this point in the history