plugin_actions: Extend line in actions config file by "reserved" item #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like there are some actions plugin CI tests this is breaking. |
I plan to extend functionality of actions plugin in the future. I want to add a new configuration item. Changing the configuration format later - when it will be documented and used is not good. So now I'm adding one "reserved" item. Old format: callback_name:package_filter:direction:command New format: callback_name:package_filter:direction:reserved:command The plugin version is increased to 0.2.0.
jrohel
force-pushed
the
libdnf_actions_plugin_add_item
branch
from
edb9cd4
to
ba703b6
Compare
|
@kontura I adjusted ci tests PR rpm-software-management/ci-dnf-stack#1335 |
Merged
via the queue into
rpm-software-management:main
with commit Jul 13, 2023
6e63aa8
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to extend functionality of actions plugin in the future. I want to add a new configuration item. Changing the configuration format later - when it will be documented and used is not good. So now I'm adding one "reserved" item.
Old format:
callback_name:package_filter:direction:command
New format:
callback_name:package_filter:direction:reserved:command
Requires adjustment of ci tests rpm-software-management/ci-dnf-stack#1335