Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert default of allow_vendor_change to true #745

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

j-mracek
Copy link
Contributor

@j-mracek j-mracek commented Jul 20, 2023

We discovered several issues related to the feature.

Command line packages are refused to get installed when they have a different vendor.

Disabling copr repository results in refusing installation of packages and upgrades from original repositories - skipping all upgrades.

Cryptic solver message

  • it is impossible to guess that the real issue is related to a different vendor of both packages
  • cannot install both dnf5-5.0.13-2.fc38.x86_64 and dnf5-5.1.0-20230719020203.0.gc17c4f61.fc38.x86_64 repoquery info does not show vendor

Closes: #738
Closes: #701
Closes: #722

We discovered several issues related to the feature.

Command line packages are refused to get installed when they have
a different vendor.

Disabling copr repository results in refusing installation of packages
and upgrades from original repositories - skipping all upgrades.

Cryptic solver message
 - it is impossible to guess that the real issue is related to
 a different vendor of both packages
 - cannot install both dnf5-5.0.13-2.fc38.x86_64 and dnf5-5.1.0-20230719020203.0.gc17c4f61.fc38.x86_64
    repoquery info does not show vendor
@Conan-Kudo
Copy link
Member

We definitely need to add some output for sticky vendor cases so that the behavior is obvious and people know what to do. Do we want to have a session of some kind to figure it out? I'd really like for us to have this in as default at some point soon, especially because vendor switching should be purposeful rather than implicit.

@inknos
Copy link
Collaborator

inknos commented Jul 20, 2023

We definitely need to add some output for sticky vendor cases so that the behavior is obvious and people know what to do. Do we want to have a session of some kind to figure it out? I'd really like for us to have this in as default at some point soon, especially because vendor switching should be purposeful rather than implicit.

Hey @Conan-Kudo, I opened an issue to track that #750

Meanwhile, I would go on with this PR to fix fedora 39 urgencies.

@inknos inknos added this pull request to the merge queue Jul 20, 2023
Merged via the queue into rpm-software-management:main with commit 0019b12 Jul 20, 2023
5 of 6 checks passed
@Conan-Kudo
Copy link
Member

I'm fine with this, we should track for enabling by Fedora 40, though.

@j-mracek
Copy link
Contributor Author

j-mracek commented Aug 7, 2023

I'm fine with this, we should track for enabling by Fedora 40, though.

I think Fedora 40 is not realistic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
3 participants