Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTRIBUTING: don't mention "ready-for-review" #905

Merged
merged 1 commit into from
Sep 21, 2023
Merged

CONTRIBUTING: don't mention "ready-for-review" #905

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,9 @@ If you need any help when contributing to the project, reach out to us either of
Once you have a contribution ready, complete the following steps to submit the contribution:

1. Submit a pull request (PR).
1. Set the necessary [labels](https://github.com/rpm-software-management/dnf5/labels).
* If you need help while working on the PR, set the
[_work in progress_](https://github.com/rpm-software-management/dnf5/labels/work%20in%20progress) label
and wait for the PR to be triaged. Triaging usually happens on Mondays or Thursdays.
* If you are ready for a code review by one of the maintainers, set the
[_ready for review_](https://github.com/rpm-software-management/dnf5/labels/ready%20for%20review) label.
* If the PR is not yet ready to be reviewed by the maintainers, create a
"Draft Pull Request". Then, when it's ready, mark it as "Ready for
review".
2. Review the PR.
1. Discuss the PR with one of the maintainers. Note that the maintainers might request some changes.
2. Review the PR again.
Expand Down
Loading