Make --forcearch a global argument
#941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-mracek
reviewed
Oct 5, 2023
evan-goode
force-pushed
the
evan-goode/global-forcearch
branch
from
01abef0
to
7626ecc
Compare
j-mracek
reviewed
Oct 11, 2023
|
If I am not mistaken, we agreed with the team to use deprivation warning raised during compilation, and to keep the same functionality for deprecated method even if it is unused API and there is low chance that is in use from other project. |
evan-goode
force-pushed
the
evan-goode/global-forcearch
branch
from
7626ecc
to
24cf087
Compare
|
OK, I've kept the original |
|
I was just on way to merge it and I discovered that there is a merge conflict. @evan-goode May I ask you for a rebase? |
j-mracek
approved these changes
Oct 17, 2023
evan-goode
force-pushed
the
evan-goode/global-forcearch
branch
from
24cf087
to
7a36a61
Compare
Many commands respect --forcearch (distro-sync, download, install, list, makecache, repoquery, search, etc.) so it makes sense to make --forcearch a global argument that can be used with any command. Resolves rpm-software-management#872
evan-goode
force-pushed
the
evan-goode/global-forcearch
branch
from
7a36a61
to
a8947f7
Compare
Merged
via the queue into
rpm-software-management:main
with commit Oct 18, 2023
8b515b7
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many commands respect
--forcearch(distro-sync, download, install, list, makecache, repoquery, search, etc.) so it makes sense to make--forcearcha global argument that can be used with any command.Resolves #872