Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cap converted genome length #7

Closed
MikeWLloyd opened this issue Mar 21, 2023 · 1 comment
Closed

Cap converted genome length #7

MikeWLloyd opened this issue Mar 21, 2023 · 1 comment

Comments

@MikeWLloyd
Copy link

MikeWLloyd commented Mar 21, 2023 •
edited
Loading

This is a feature request rather than an issue. Due to the extrapolation function, conversions can exceed the length of chromosomes. Is it possible to include a warning when the conversion exceeds chrom build length?
kbroman added a commit to kbroman/mmconvert that referenced this issue Mar 23, 2023
@kbroman
mmconvert gives warning if positions are out of range
22c4ab6 
- Added dataset `grcm39_chrlen` with lengths of GRCm39 chromosomes
  in basepairs.

- Revised mmconvert to give warnings if inferred positions are outside
  of the range of chromosomes in GRCm39. (Issue rqtl#7)

- In `cross2_to_grcm39()` when using "guess", only pick the GM/MM
  combination if it gives >20 additional markers than either GM or MM
  on their own.
@MikeWLloyd
Copy link
Author

Thanks for adding the feature! It will be helpful to what I was trying to do. I appreciate the really fast turn around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MikeWLloyd