pack: Restore behavior with no passed trace dirs #3842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit of an embarassing bug-fix, but as pointed out in rr-debugger#3834 (comment), I accidentally broke `rr pack` without trace dir specified (which is supposed to pack the latest dir). We do actually have a test for it, which does fail for me locally (which I didn't notice - sorry), but not on CI. I'm not entirely sure why it doesn't fail on CI, but I imagine we might be copying more things in the CI environment, rather than cloning/linking them. To try to catch similar regressions in the future, this also adds an extra check to the test to make sure that there is some `mmap_pack_*` file in the trace after packing. I think we should always be packing at least libc or ld-linux, so hopefully there shouldn't be any false positives there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of an embarassing bug-fix, but as pointed out in #3834 (comment), I accidentally broke
rr packwithout trace dir specified (which is supposed to pack the latest dir). We do actually have a test for it, which does fail for me locally (which I didn't notice - sorry), but not on CI. I'm not entirely sure why it doesn't fail on CI, but I imagine we might be copying more things in the CI environment, rather than cloning/linking them. To try to catch similar regressions in the future, this also adds an extra check to the test to make sure that there is somemmap_pack_*file in the trace after packing. I think we should always be packing at least libc or ld-linux, so hopefully there shouldn't be any false positives there.