Unconditionally style contents of L<> tags
#21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets users properly highlight man(1) references even if guesswork doesn't report it as a manref. The offending links looked something like this: @@RXVT_NAME@@Perl(3) Being able to wrap these in `L<>` to bold the entire string is a nicety
mjsir911
commented
Apr 25, 2023
| @@ -1321,8 +1323,11 @@ sub cmd_l { | |||
| } else { | |||
| return "$text <$$attrs{to}>"; | |||
| } | |||
| } elsif ($$attrs{type} eq 'man') { | |||
| my ($page, $section) = $text =~ /^([^(]+)(?:[(](\d+)[)])?$/; # Copied from Simple.pm | |||
| return '\f(BS' . $page . '\f(BE\|' . "($section)"; | |||
There was a problem hiding this comment.
Is there a better way to apply the bold formatting than using the format codes?
mjsir911
changed the title
L<> tags
|
Thank you for the analysis and the initial patch! I have a committed a fix for this that will be in the next release. The problem was a bit more complex than your patch, because by the time |
|
Thank you @rra! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets users properly highlight man(1) references even if guesswork doesn't report it as a manref. The offending links looked something like this:
@@RXVT_NAME@@perl(3)Being able to wrap these in
L<>to bold the entire string is a nicety.A (too) thorough writeup, exploration, & justification of this PR can be found here
TODO: