New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes unused function warning in MixEnv check #1090

Merged

rrrene merged 1 commit into rrrene:master from antedeguemon:vm-fixes-unused-function-from-mix-env-check

Nov 17, 2023

Contributor

antedeguemon commented Nov 17, 2023

Hi! 🖖

There is a warning getting logged when compiling Credo.Check.Warning.MixEnv:

❯ mix compile lib/credo/check/warning/mix_env.ex
Compiling 1 file (.ex)
    warning: function traverse/4 is unused
    │
 56 │     defp traverse({unquote(op), _, nil} = ast, issues, _issue_meta, _parens?) do
    │          ~
    │
    └─ lib/credo/check/warning/mix_env.ex:56:10: Credo.Check.Warning.MixEnv (module)

This pull request fixes it by removing the extra parens? argument from the traverse function and adds a little test to ensure nothing is broken.


          Fixes unused function from Warning.MixEnv

2346b43

rrrene merged commit a8f661f into rrrene:master

10 of 11 checks passed

antedeguemon deleted the vm-fixes-unused-function-from-mix-env-check branch

November 17, 2023 18:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet