Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation for 1.17 #1125

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Fix deprecation for 1.17 #1125

merged 1 commit into from
Apr 29, 2024

Conversation

mhanberg
Copy link
Contributor

1.17 deprecates calling remote functions without parentheses, which
means that calls like Foo.Bar.run and foo = %{bar: Foo}; foo.bar.run
should instead be formatted like
Foo.Bar.run() and foo = %{bar: Foo}; foo.bar.run()

This show up as runtime warnings.

1.17 deprecates calling remote functions without parentheses, which
means that calls like `Foo.Bar.run` and `foo = %{bar: Foo}; foo.bar.run`
should instead be formatted like
`Foo.Bar.run()` and `foo = %{bar: Foo}; foo.bar.run()`

This show up as runtime warnings.
@rrrene
Copy link
Owner

rrrene commented Apr 28, 2024

I will merge this soon! Thx for bringing this up 👍

@rrrene rrrene merged commit 1ac1ee6 into rrrene:master Apr 29, 2024
18 of 19 checks passed
@mhanberg mhanberg deleted the fix-deprecatoins branch April 29, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants