Single style capture #1437

… checking the replay took me ages to debug as I thought it was something I introducedg

…rweb-io#1417

… mutations with `absoluteToStylesheet` - I had accidentally removed that with initial work

…yStylesheet to happen in a single place during initial snapshot.

…tyle> need to be tracked

…n't being assigned to correct text node, and provide remedy whereby css text is properly re-split upon rebuild

…extSplits`

…e round

…our there and some explanatory comments

…hat the css hasn't been altered server-side/in-transit

… second text child instead of the first

…ion, even if there is only one text element on the <style>. Recent conversation with Justin has firmed up my thinking on why we look at .sheet in the first place (it's not because we want to get rid of vendor prefixes, which may actually be undesirable where they are useful for accurate replay in the replayer - but rather it's to ensure we don't miss any programmatic style mutations that have happened - have added comments to reflect this)

rrweb:test: test/utils.ts:181:43 - error TS2345: Argument of type 'elementNode & { rootId?: number | undefined; isShadowHost?: boolean | undefined; isShadow?: boolean | undefined; } & { id: number; }' is not assignable to parameter of type '{ attributes: { src?: string | undefined; }; }'. rrweb:test: Types of property 'attributes' are incompatible. rrweb:test: Type 'attributes' has no properties in common with type '{ src?: string | undefined; }'. rrweb:test: rrweb:test: 181 stripBlobURLsFromAttributes(add.node);

…'record and replay style mutations')

…bute, mark the splits directly within the _cssText using CSS comments

…tin and Yun - 'cssCaptured' should dovetail better with the stylesheet-assets branch where capturing will happen asynchronously

…should be covering all cases; would have only come into play if `applyCssSplits` was called without any child text nodes, which I can't imagine happening

…t getting rebuilt with `adaptCssForReplay`

…utation

…ext content, but I was mistaken; adding as I think it still has value in terms of regression

…te content in mutation between _cssText and a text node

…de after a mutation as it's textContent wasn't getting a serialized id

…ple child nodes Add a new integration test to verify that style mutations with multiple child nodes are recorded and replayed correctly. The test sets the color of two div elements using CSS and verifies that the color is applied correctly after replaying the recorded events.

- Don't record css content twice when a <style> element is added in a mutation - Fix case where we wouldn't have been able to mutate a <style> text node after a mutation as it's textContent wasn't getting a serialized id

…y style mutations' covers more ground. Could probably emphasize that these 2 are related to `insertRule` i.e. programmatic mutations as opposed to text mutations

The prior 'dynamic stylesheet' route is now the main route for serializing a stylesheet; dynamic stylesheet were missed out in rrweb-io#1533 but are caught in this PR by the tests added in that PR as the stylesheet handling is simplified/centralised

…ns entire css text when there are too few child nodes' passes Co-authored-by: Justin Halsall <[email protected]>

Co-authored-by: Justin Halsall <[email protected]>

…tyle.sheet

…sString` function (thanks Justin). Add test to show when this matters

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Single style capture #1437

Single style capture #1437

Commits on Aug 2, 2024