Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inlineImages: Setting of image.crossOrigin is not always necessary #1468

Merged
merged 13 commits into from
May 23, 2024
Merged

inlineImages: Setting of image.crossOrigin is not always necessary #1468

merged 13 commits into from
May 23, 2024

Commits on May 22, 2024

  1. Setting of image.crossOrigin is not necessary for same origin image… 

    …s, and causes an immediate image reload necessitating the load event listener (albeit from cache)
    @eoghanmurray
    eoghanmurray committed May 22, 2024
    Configuration menu
    Copy the full SHA
    3f18f91 View commit details
    Browse the repository at this point in the history

  2. It's good that these mutations are avoided; they were being generated… 

    … by the snapshotting process
    @eoghanmurray
    eoghanmurray committed May 22, 2024
    Configuration menu
    Copy the full SHA
    2817513 View commit details
    Browse the repository at this point in the history

  3. Fixup typings

    @eoghanmurray
    eoghanmurray committed May 22, 2024
    Configuration menu
    Copy the full SHA
    d6e4fff View commit details
    Browse the repository at this point in the history

  4. Apply formatting changes

    @eoghanmurray
    eoghanmurray committed May 22, 2024
    Configuration menu
    Copy the full SHA
    29354ac View commit details
    Browse the repository at this point in the history

  5. Improve jest/expect in picture test

    @eoghanmurray
    eoghanmurray committed May 22, 2024
    Configuration menu
    Copy the full SHA
    42f3ed8 View commit details
    Browse the repository at this point in the history

  6. Add a test for using the image.crossOrigin = 'anonymous'; hack

    @eoghanmurray
    eoghanmurray committed May 22, 2024
    Configuration menu
    Copy the full SHA
    0277f43 View commit details
    Browse the repository at this point in the history

  7. Bugfix: after the crossOrigin change we always need to listen for the… 

    … load, as calling `recordInlineImage` immediately will result in an empty data url
    @eoghanmurray
    eoghanmurray committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f0cca66 View commit details
    Browse the repository at this point in the history

  8. Improve how test failures look; flatten was overkill

    @eoghanmurray
    eoghanmurray committed May 22, 2024
    Configuration menu
    Copy the full SHA
    afd7234 View commit details
    Browse the repository at this point in the history

  9. Repeat image.complete check for completeness

    @eoghanmurray
    eoghanmurray committed May 22, 2024
    Configuration menu
    Copy the full SHA
    2e466e7 View commit details
    Browse the repository at this point in the history

  10. Didn't notice that the picture.html used in 'correctly saves images o… 

    …ffline' is also separately checked against a __snapshot__
    @eoghanmurray
    eoghanmurray committed May 22, 2024
    Configuration menu
    Copy the full SHA
    c9d6a65 View commit details
    Browse the repository at this point in the history

  11. Update packages/rrweb-snapshot/test/integration.test.ts

    @Juice10 @eoghanmurray
    Juice10 authored and eoghanmurray committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f8cbf9c View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Don't rely on a 3rd party url (or internet access) in the new cross-o… 

    …rigin test
    @eoghanmurray
    eoghanmurray committed May 23, 2024
    Configuration menu
    Copy the full SHA
    d2df9bb View commit details
    Browse the repository at this point in the history

  2. fixup! Update packages/rrweb-snapshot/test/integration.test.ts

    @eoghanmurray
    eoghanmurray committed May 23, 2024
    Configuration menu
    Copy the full SHA
    ba7ca2d View commit details
    Browse the repository at this point in the history