Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extension doesn't work after vite bump #1507

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

YunFeng0817
Copy link
Member

In #1033, the dependency vite-plugin-web-extension for extension package was upgraded as well along with vite
There are some breaking changes for vite-plugin-web-extension.

@YunFeng0817 YunFeng0817 requested a review from Juice10 June 12, 2024 09:39
Copy link

changeset-bot bot commented Jun 12, 2024

🦋 Changeset detected

Latest commit: 9d0d32c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Juice10
Copy link
Contributor

Juice10 commented Jun 12, 2024

Good catch, @YunFeng0817!

@Juice10 Juice10 merged commit 4beaf2d into master Jun 12, 2024
11 checks passed
@Juice10 Juice10 deleted the fix-extension-build branch June 12, 2024 12:59
jeffdnguyen pushed a commit to pendo-io/rrweb that referenced this pull request Jul 29, 2024
* fix: extension doesn't work after vite bump
jeffdnguyen pushed a commit to pendo-io/rrweb that referenced this pull request Jul 29, 2024
* fix: extension doesn't work after vite bump
jxiwang pushed a commit to amplitude/rrweb that referenced this pull request Oct 22, 2024
* fix: extension doesn't work after vite bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants