ref: isParentRemoved to cache subtree #1543

JonasBa · 2024-07-20T13:35:05Z

isParentRemoved is called super often for each node that we add. I think the current logic results in an On^2 time complexity as each visit to a node traverser the entire chain of parents (please correct me if I'm wrong).

The motivation behind this change is to iterate on the graph once ahead of time which can be done in On time and store the parent nodes which were removed. That way we can query the removed set in O1 time and only perform this lookup once per node

Related to #1271

changeset-bot · 2024-07-20T13:35:10Z

🦋 Changeset detected

Latest commit: b10de2e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages

Name	Type
rrweb	Major
@rrweb/rrweb-plugin-canvas-webrtc-record	Major
@rrweb/rrweb-plugin-canvas-webrtc-replay	Major
@rrweb/rrweb-plugin-console-record	Major
@rrweb/rrweb-plugin-console-replay	Major
@rrweb/rrweb-plugin-sequential-id-record	Major
@rrweb/rrweb-plugin-sequential-id-replay	Major
rrweb-snapshot	Major
rrdom	Major
rrdom-nodejs	Major
rrweb-player	Major
@rrweb/all	Major
@rrweb/replay	Major
@rrweb/record	Major
@rrweb/types	Major
@rrweb/packer	Major
@rrweb/utils	Major
@rrweb/web-extension	Major
rrvideo	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

JonasBa · 2024-07-20T13:57:20Z

@eoghanmurray I think this will substantially improve performance for nested trees. We dont really benchmark these much besides the deep nested tree test I added, but this shows a 30% improvement on the create 1000x 1 DOM nodes with deeply nested children benchmark. On a side note, I think we should work on making the output of benchmarks friendlier as it's kind of annoying to share.

Before

After

…rf/isparentremoved

Juice10 · 2024-09-17T09:20:07Z

On a side note, I think we should work on making the output of benchmarks friendlier as it's kind of annoying to share.

@JonasBa totally agree with you, I've spent some time integrating vitest's benchmark features which should help. Here is an example output for this performance improvement, which would suggest that your performance improvement really hit its mark:

 ✓ test/benchmark/dom-mutation.bench.ts (12) 377261ms
   ✓ benchmark: mutation observer: 'create 1000x 1 DOM nodes with deeply …' (2) 247290ms
     name              hz       min        max       mean        p75        p99       p995       p999      rme  samples
   · local rrweb   0.2603    750.04   6,525.87   3,841.00   5,304.50   6,525.87   6,525.87   6,525.87  ±34.37%       10   fastest
   · latest rrweb  0.0659  1,922.43  27,734.97  15,167.97  22,735.11  27,734.97  27,734.97  27,734.97  ±39.73%       10
   ✓ benchmark: mutation observer: 'create 1000x10 DOM nodes' (2) 35445ms
     name              hz     min       max      mean       p75       p99      p995      p999      rme  samples
   · local rrweb   0.7420  222.91  2,521.98  1,347.76  1,932.18  2,521.98  2,521.98  2,521.98  ±39.86%       10   fastest
   · latest rrweb  0.7333  222.95  2,571.04  1,363.65  1,971.98  2,571.04  2,571.04  2,571.04  ±40.14%       10
   ✓ benchmark: mutation observer: 'create 1000x10x2 DOM nodes and remove…' (2) 56692ms
     name              hz     min       max      mean       p75       p99      p995      p999      rme  samples
   · local rrweb   0.6453  311.46  2,656.83  1,549.71  2,165.12  2,656.83  2,656.83  2,656.83  ±34.16%       10   fastest
   · latest rrweb  0.3609  323.76  4,819.88  2,771.15  3,986.68  4,819.88  4,819.88  4,819.88  ±36.90%       10
   ✓ benchmark: mutation observer: 'create 1000 DOM nodes and append into…' (2) 6043ms
     name              hz     min     max    mean     p75     p99    p995    p999      rme  samples
   · local rrweb   3.8657  105.66  368.41  258.69  328.98  368.41  368.41  368.41  ±48.83%        5
   · latest rrweb  3.9143  106.55  362.30  255.48  324.03  362.30  362.30  362.30  ±48.45%        5   fastest
   ✓ benchmark: mutation observer: 'create 10000 DOM nodes and move it to…' (2) 24879ms
     name              hz     min       max      mean       p75       p99      p995      p999      rme  samples
   · local rrweb   0.8378  347.70  1,915.17  1,193.59  1,605.66  1,915.17  1,915.17  1,915.17  ±63.53%        5   fastest
   · latest rrweb  0.8371  342.64  1,916.61  1,194.61  1,612.96  1,916.61  1,916.61  1,916.61  ±63.76%        5
   ✓ benchmark: mutation observer: 'modify attributes on 10000 DOM nodes' (2) 6900ms
     name              hz     min     max    mean     p75     p99    p995    p999     rme  samples
   · local rrweb   5.0940  162.96  240.62  196.31  209.97  240.62  240.62  240.62  ±8.65%       10   fastest
   · latest rrweb  5.0144  165.47  240.62  199.42  212.38  240.62  240.62  240.62  ±8.81%       10


 BENCH  Summary

  local rrweb - test/benchmark/dom-mutation.bench.ts > benchmark: mutation observer: 'create 1000x 1 DOM nodes with deeply …'
    3.95x faster than latest rrweb

  local rrweb - test/benchmark/dom-mutation.bench.ts > benchmark: mutation observer: 'create 1000x10 DOM nodes'
    1.01x faster than latest rrweb

  local rrweb - test/benchmark/dom-mutation.bench.ts > benchmark: mutation observer: 'create 1000x10x2 DOM nodes and remove…'
    1.79x faster than latest rrweb

  latest rrweb - test/benchmark/dom-mutation.bench.ts > benchmark: mutation observer: 'create 1000 DOM nodes and append into…'
    1.01x faster than local rrweb

  local rrweb - test/benchmark/dom-mutation.bench.ts > benchmark: mutation observer: 'create 10000 DOM nodes and move it to…'
    1.00x faster than latest rrweb

  local rrweb - test/benchmark/dom-mutation.bench.ts > benchmark: mutation observer: 'modify attributes on 10000 DOM nodes'
    1.02x faster than latest rrweb

JonasBa · 2024-09-18T14:04:57Z

On a side note, I think we should work on making the output of benchmarks friendlier as it's kind of annoying to share.

@JonasBa totally agree with you, I've spent some time integrating vitest's benchmark features which should help. Here is an example output for this performance improvement, which would suggest that your performance improvement really hit its mark:

 ✓ test/benchmark/dom-mutation.bench.ts (12) 377261ms
   ✓ benchmark: mutation observer: 'create 1000x 1 DOM nodes with deeply …' (2) 247290ms
     name              hz       min        max       mean        p75        p99       p995       p999      rme  samples
   · local rrweb   0.2603    750.04   6,525.87   3,841.00   5,304.50   6,525.87   6,525.87   6,525.87  ±34.37%       10   fastest
   · latest rrweb  0.0659  1,922.43  27,734.97  15,167.97  22,735.11  27,734.97  27,734.97  27,734.97  ±39.73%       10
   ✓ benchmark: mutation observer: 'create 1000x10 DOM nodes' (2) 35445ms
     name              hz     min       max      mean       p75       p99      p995      p999      rme  samples
   · local rrweb   0.7420  222.91  2,521.98  1,347.76  1,932.18  2,521.98  2,521.98  2,521.98  ±39.86%       10   fastest
   · latest rrweb  0.7333  222.95  2,571.04  1,363.65  1,971.98  2,571.04  2,571.04  2,571.04  ±40.14%       10
   ✓ benchmark: mutation observer: 'create 1000x10x2 DOM nodes and remove…' (2) 56692ms
     name              hz     min       max      mean       p75       p99      p995      p999      rme  samples
   · local rrweb   0.6453  311.46  2,656.83  1,549.71  2,165.12  2,656.83  2,656.83  2,656.83  ±34.16%       10   fastest
   · latest rrweb  0.3609  323.76  4,819.88  2,771.15  3,986.68  4,819.88  4,819.88  4,819.88  ±36.90%       10
   ✓ benchmark: mutation observer: 'create 1000 DOM nodes and append into…' (2) 6043ms
     name              hz     min     max    mean     p75     p99    p995    p999      rme  samples
   · local rrweb   3.8657  105.66  368.41  258.69  328.98  368.41  368.41  368.41  ±48.83%        5
   · latest rrweb  3.9143  106.55  362.30  255.48  324.03  362.30  362.30  362.30  ±48.45%        5   fastest
   ✓ benchmark: mutation observer: 'create 10000 DOM nodes and move it to…' (2) 24879ms
     name              hz     min       max      mean       p75       p99      p995      p999      rme  samples
   · local rrweb   0.8378  347.70  1,915.17  1,193.59  1,605.66  1,915.17  1,915.17  1,915.17  ±63.53%        5   fastest
   · latest rrweb  0.8371  342.64  1,916.61  1,194.61  1,612.96  1,916.61  1,916.61  1,916.61  ±63.76%        5
   ✓ benchmark: mutation observer: 'modify attributes on 10000 DOM nodes' (2) 6900ms
     name              hz     min     max    mean     p75     p99    p995    p999     rme  samples
   · local rrweb   5.0940  162.96  240.62  196.31  209.97  240.62  240.62  240.62  ±8.65%       10   fastest
   · latest rrweb  5.0144  165.47  240.62  199.42  212.38  240.62  240.62  240.62  ±8.81%       10


 BENCH  Summary

  local rrweb - test/benchmark/dom-mutation.bench.ts > benchmark: mutation observer: 'create 1000x 1 DOM nodes with deeply …'
    3.95x faster than latest rrweb

  local rrweb - test/benchmark/dom-mutation.bench.ts > benchmark: mutation observer: 'create 1000x10 DOM nodes'
    1.01x faster than latest rrweb

  local rrweb - test/benchmark/dom-mutation.bench.ts > benchmark: mutation observer: 'create 1000x10x2 DOM nodes and remove…'
    1.79x faster than latest rrweb

  latest rrweb - test/benchmark/dom-mutation.bench.ts > benchmark: mutation observer: 'create 1000 DOM nodes and append into…'
    1.01x faster than local rrweb

  local rrweb - test/benchmark/dom-mutation.bench.ts > benchmark: mutation observer: 'create 10000 DOM nodes and move it to…'
    1.00x faster than latest rrweb

  local rrweb - test/benchmark/dom-mutation.bench.ts > benchmark: mutation observer: 'modify attributes on 10000 DOM nodes'
    1.02x faster than latest rrweb

Nice work @Juice10, is that available on master? I need to rebase some of these PRs, and I will remove the script benchmark change here (iirc I added it because something was broken)

Juice10 · 2024-09-19T05:51:09Z

@JonasBa Not yet on master, but hopefully I'll be able to finish it and create a PR for it today

JonasBa · 2024-09-19T14:41:52Z

Sounds good, I went ahead and reverted the change to the profiling script

JonasBa · 2024-09-23T11:43:47Z

@Juice10 Can we merge this, or do we need a separate review?

Juice10 · 2024-10-04T09:31:11Z

Thanks Jonas!

JonasBa · 2024-10-04T13:08:10Z

Thank you @Juice10!

@Paulhejia

* Skip mask check on leaf elements (rrweb-io#1512) * Minor fixup for rrweb-io#1349; the 'we can avoid the check on leaf elements' optimisation wasn't being applied as `n.childNodes` was always truthy even when there were no childNodes. Changing it to `n.childNodes.length` directly there (see rrweb-io#1402) actually caused a bug as during a mutation, we serialize the text node directly, and need to jump to the parentElement to do the check. This is why I've reimplemented this optimisation inside `needMaskingText` where we are already had an `isElement` test Thanks to @Paulhejia (https://github.com/Paulhejia/rrweb/) for spotting that `Boolean(n.childNodes)` is aways true. * Assuming all jest should have been removed in rrweb-io#1033 (rrweb-io#1511) * all references to jest should have been removed in rrweb-io#1033 * clarify that `cross-env` is used to ensure that environmental variables get applied on Windows (previous usage of cross-env was removed in rrweb-io#1033) * Fix async assertions in test files (rrweb-io#1510) * fix: await assertSnapshot in test files for async assertions * Fix maskInputFn is ignored during the creation of the full snapshot (rrweb-io#1386) Fix that the optional `maskInputFn` was being accidentally ignored during the creation of the full snapshot * Improve development tooling (rrweb-io#1516) - Running `yarn build` in a `packages/*/` directory will trigger build of all dependencies too, and cache them if possible. - Fix for `yarn dev` breaking for `rrweb` package whenever changing files in `rrweb` package - Update typescript, turbo, vite and vite-plugin-dts - Require `workspaces-to-typescript-project-references` from `prepublish` * Version Packages (alpha) (rrweb-io#1513) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Keep all packages in sync * feat: add new css parser - postcss (rrweb-io#1458) * feat: add new css parser * make selectors change * selectors and tests * media changes * remove old css references * better variable name * use postcss and port tests * fix media test * inline plugins * fix failing multiline selector * correct test result * move tests to correct file * cleanup all tests * remove unused css-tree * update bundle * cleanup dependencies * revert config files to master * remove d.ts files * update snapshot * reset rebuilt test * apply fuzzy css matching * remove extra test * Fix imports * Newer versions of nswapi break rrdom-nodejs tests. Example: FAIL test/document-nodejs.test.ts > RRDocument for nodejs environment > RRDocument API > querySelectorAll TypeError: e[api] is not a function ❯ byTag ../../node_modules/nwsapi/src/nwsapi.js:390:37 ❯ Array.<anonymous> ../../node_modules/nwsapi/src/nwsapi.js:327:113 ❯ collect ../../node_modules/nwsapi/src/nwsapi.js:1578:32 ❯ Object._querySelectorAll [as select] ../../node_modules/nwsapi/src/nwsapi.js:1533:36 ❯ RRDocument.querySelectorAll src/document-nodejs.ts:96:24 * Migrate from jest to vitest * Order of selectors has changed with postcss * Remove unused eslint --------- Co-authored-by: Justin Halsall <[email protected]> * fix: console assert only logs when arg 0 is falsy (rrweb-io#1530) * fix: console assert only logs when arg 0 is falsy * [Feature] Include takeFullSnapshot function in rrweb (rrweb-io#1527) * export takeFullSnapshot function in rrweb * chore: reduce flakey test due to '[vite] connected' message (rrweb-io#1525) * fix: duplicate textContent for style element cause incremental style mutation invalid (rrweb-io#1417) fix style element corner case - historically we have recorded duplicated css content in certain cases (demonstrated by the attached replayer test). This fix ensures that the replayer doesn't doubly add the content, which can cause problems when further mutations occur --------- Review and further tests contributed by: Eoghan Murray <[email protected]> * Added support for deprecated addRule & removeRule methods (rrweb-io#1515) * Added support for deprecated addRule & removeRule methods * Respect addRule default value * fix: nested stylesheets should have absolute URLs (rrweb-io#1533) * Replace relative URLs with absolute URLs when stringifying stylesheets * Add test to show desired behavior for imported stylesheets from seperate directory * Rename `absoluteToStylesheet` to `absolutifyURLs` and call it once after stringifying imported stylesheet * Don't create the intermediary array of the spread operator * Formalize that `stringifyRule` should expect a sheet href * Ensure a <style> element can also import and gets it's url absolutized * Handle case where non imported stylesheet has relative urls that need to be absolutified * Clarify in test files where jpegs are expected to appear in absolutified urls * Move absolutifyURLs call for import rules out of trycatch * Add a benchmarking test for stringifyStylesheet * Avoid the duplication on how to fall back --------- Co-authored-by: Eoghan Murray <[email protected]> Co-authored-by: eoghanmurray <[email protected]> * Support top-layer <dialog> recording & replay (rrweb-io#1503) * chore: its important to run `yarn build:all` before running `yarn dev` * feat: trigger showModal from rrdom and rrweb * feat: Add support for replaying modal and non modal dialog elements * chore: Update dev script to remove CLEAR_DIST_DIR flag * Get modal recording and replay working * DRY up dialog test and dedupe snapshot images * feat: Refactor dialog test to use updated attribute name * feat: Update dialog test to include rr_open attribute * chore: Add npm dependency [email protected] * Add more test cases for dialog * Clean up naming * Refactor dialog open code * Revert changed code that doesn't do anything * Add documentation for unimplemented type * chore: Remove unnecessary comments in dialog.test.ts * rename rr_open to rr_openMode * Replace todo with a skipped test * Add better logging for CI * Rename rr_openMode to rr_open_mode rrdom downcases all attribute names which made `rr_openMode` tricky to deal with * Remove unused images * Move after iframe append based on @YunFeng0817's comment rrweb-io#1503 (comment) * Remove redundant dialog handling from rrdom. rrdom already handles dialog element creation it's self * Rename variables for dialog handling in rrweb replay module * Update packages/rrdom/src/document.ts --------- Co-authored-by: Eoghan Murray <[email protected]> * Added session downloader for chrome extension (rrweb-io#1522) * Added session downloader for chrome extension - The session list now has a button to download sessions as .json files for use with rrweb-player - Improved styling for the delete and download buttons * Reverse monkey patch built in methods to support LWC (rrweb-io#1509) * Get around monkey patched Nodes * inlineImages: Setting of `image.crossOrigin` is not always necessary (rrweb-io#1468) Setting of the `crossorigin` attribute is not necessary for same-origin images, and causes an immediate image reload (albeit from cache) necessitating the use of a load event listener which subsequently mutates the snapshot. This change allows us to avoid the mutation of the snapshot for the same-origin case. * Modify inlineImages test to remove delay and show that we can inline images without mutation * Add an explicit test for when the `image.crossOrigin = 'anonymous';` method is necessary. Uses a combination of about:blank and our test server to simulate a cross-origin context * Other test changes: there were some spurious rrweb mutations being generated by the addition of the crossorigin attribute that are now elimnated from the rrweb/__snapshots__/integration.test.ts.snap after this PR - this is good * Move `childNodes` to @rrweb/utils * Use non-monkey patched versions of the `childNodes`, `parentNode` `parentElement` `textContent` accessors * Add getRootNode and contains, and add comprehensive todo list * chore: Update turbo.json tasks for better build process * Update caniuse-lite * chore: Update eslint-plugin-compat to version 5.0.0 * chore: Bump @rrweb/utils version to 2.0.0-alpha.15 * delete unused yarn.lock files * Set correct @rrweb/utils version in package.json * Migrate over some accessors to reverse-monkey-patched version * Add missing functions * Fix illegal invocation error * Revert closer to what it was. This feels incorrect to me (Justin Halsall), but some of the tests break without it so I'm restoring this to be closer to its original here: https://github.com/rrweb-io/rrweb/blame/cfd686d488a9b88dba6b6f8880b5e4375dd8062c/packages/rrweb-snapshot/src/snapshot.ts#L1011 * Reverse monkey patch all methods LWC hijacks * Make tests more stable * Safely handle rrdom nodes in hasShadowRoot * Remove duplicated test * Use variable `serverURL` in test * Use monorepo default browserlist * Fix typing issue for new typescript * Remove unused package * Remove unused code * Add prefix to reverse-monkey-patched methods to make them more explicit * Add default exports to @rrweb/utils --------- Co-authored-by: Eoghan Murray <[email protected]> * Version Packages (alpha) (rrweb-io#1526) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Single style capture (rrweb-io#1437) Support a contrived/rare case where a <style> element has multiple text node children (this is usually only possible to recreate via javascript append) ... this PR fixes cases where there are subsequent text mutations to these nodes; previously these would have been lost * In this scenario, a new CSS comment may now be inserted into the captured `_cssText` for a <style> element to show where it should be broken up into text elements upon replay: `/* rr_split */` * The new 'can record and replay style mutations' test is the principal way to the problematic scenarios, and is a detailed 'catch-all' test with many checks to cover most of the ways things can fail * There are new tests for splitting/rebuilding the css using the rr_split marker * The prior 'dynamic stylesheet' route is now the main route for serializing a stylesheet; dynamic stylesheet were missed out in rrweb-io#1533 but that case is now covered with this PR This PR was originally extracted from rrweb-io#1475 so the initial motivation was to change the approach on stringifying <style> elements to do so in a single place. This is also the motivating factor for always serializing <style> elements via the `_cssText` attribute rather than in it's childNodes; in rrweb-io#1475 we will be delaying populating `_cssText` for performance and instead recorrding them as assets. Thanks for the detailed review to Justin Halsall <[email protected]> & Yun Feng <https://github.com/YunFeng0817> * Simplify the hover replacement function (rrweb-io#1535) Simplify the hover replacement function, which has been borrowed from postcss-pseudo-classes Note: 'parses nested commas in selectors correctly' was failing after this PR, however I don't think that the previous behaviour was desirable, so have added a new test to formalize this expectation * fix some typos in optimize-storage.md (rrweb-io#1565) * fix some typos in optimize-storage.md * Update docs/recipes/optimize-storage.md * Create metal-mugs-mate.md --------- Co-authored-by: Justin Halsall <[email protected]> * fix(rrdom): Ignore invalid DOM attributes when diffing (rrweb-io#1561) * fix(rrdom): Ignore invalid DOM attributes when diffing (rrweb-io#213) We encountered an issue where replays with invalid attributes (e.g. `@click`) would break rendering the replay after seeking. The exception bubbles up to [here](https://github.com/rrweb-io/rrweb/blob/62093d4385a09eb0980c2ac02d97eea5ce2882be/packages/rrweb/src/replay/index.ts#L270-L279), which means the replay will continue to play, but the replay mirror will be incomplete. Closes https://github.com/getsentry/team-replay/issues/458 * add changeset * fix(snapshot): dimensions for blocked element not being applied (rrweb-io#1331) fix for replay of a blocked element when using 'fast forward' (rrdom) - Dimensions were not being properly applied when you seek to a position in the replay. Need to use `setProperty` rather than trying to set the width/height directly * ref: isParentRemoved to cache subtree (rrweb-io#1543) * ref: isParentRemoved to cache subtree * ref: cache at insertion too * ref: remove wrapper function --------- Co-authored-by: Justin Halsall <[email protected]> * changeset to 2.0.13 * fix snapshot build --------- Co-authored-by: Eoghan Murray <[email protected]> Co-authored-by: Justin Halsall <[email protected]> Co-authored-by: Alexey Babik <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: David Newell <[email protected]> Co-authored-by: Paul D'Ambra <[email protected]> Co-authored-by: Christopher Arredondo <[email protected]> Co-authored-by: Yun Feng <[email protected]> Co-authored-by: minja malešević <[email protected]> Co-authored-by: Jeff Nguyen <[email protected]> Co-authored-by: eoghanmurray <[email protected]> Co-authored-by: Arun Kunigiri <[email protected]> Co-authored-by: Riadh Mouamnia <[email protected]> Co-authored-by: Billy Vong <[email protected]> Co-authored-by: Jonas <[email protected]> Co-authored-by: Shay Malchi <[email protected]>

ref: isParentRemoved to cache subtree

7eb0bea

JonasBa added 3 commits July 20, 2024 09:36

ref: cache at insertion too

359be3a

ref: remove wrapper function

ed5e795

format

5d369cc

JonasBa marked this pull request as ready for review July 20, 2024 13:39

fix: benchmarks

2207201

JonasBa and others added 4 commits July 20, 2024 09:58

add changeset

9fd33b4

add comment

a1dc95b

format

08619a6

Merge branch 'master' of https://github.com/rrweb-io/rrweb into jb/pe…

bd13bc8

…rf/isparentremoved

revert profile change

b10de2e

Juice10 approved these changes Oct 4, 2024

View reviewed changes

Juice10 merged commit 53b83bb into rrweb-io:master Oct 4, 2024
6 checks passed

github-actions bot mentioned this pull request Oct 4, 2024

Version Packages (alpha) #1554

Open

github-actions bot mentioned this pull request Oct 11, 2024

Version Packages (alpha) nafees87n/rrweb#1

Open

github-actions bot mentioned this pull request Aug 19, 2024

Version Packages (alpha) pendo-io/rrweb#10

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ref: isParentRemoved to cache subtree #1543

ref: isParentRemoved to cache subtree #1543

JonasBa commented Jul 20, 2024 •

edited

Loading

changeset-bot bot commented Jul 20, 2024 •

edited

Loading

JonasBa commented Jul 20, 2024

Juice10 commented Sep 17, 2024

JonasBa commented Sep 18, 2024 •

edited

Loading

Juice10 commented Sep 19, 2024 •

edited

Loading

JonasBa commented Sep 19, 2024

JonasBa commented Sep 23, 2024

Juice10 commented Oct 4, 2024

JonasBa commented Oct 4, 2024

ref: isParentRemoved to cache subtree #1543

ref: isParentRemoved to cache subtree #1543

Conversation

JonasBa commented Jul 20, 2024 • edited Loading

changeset-bot bot commented Jul 20, 2024 • edited Loading

🦋 Changeset detected

JonasBa commented Jul 20, 2024

Juice10 commented Sep 17, 2024

JonasBa commented Sep 18, 2024 • edited Loading

Juice10 commented Sep 19, 2024 • edited Loading

JonasBa commented Sep 19, 2024

JonasBa commented Sep 23, 2024

Juice10 commented Oct 4, 2024

JonasBa commented Oct 4, 2024

JonasBa commented Jul 20, 2024 •

edited

Loading

changeset-bot bot commented Jul 20, 2024 •

edited

Loading

JonasBa commented Sep 18, 2024 •

edited

Loading

Juice10 commented Sep 19, 2024 •

edited

Loading