Add observers for stylesheet mutations #177
Conversation
|
We should squash this for sure, but let me know if the approach is how you'd go about it. |
| headless: false, | ||
| args: ['--no-sandbox'], | ||
| }); | ||
| this.browser = await launchPuppeteer(); |
There was a problem hiding this comment.
these changes are unrelated, but I was annoyed with running --watch and having the browser constantly take focus
|
Also looks like the test suite is a bit flakey (sometimes the async code doesnt finish running as expected?) Have seen it on the new tests + on: |
dcramer
force-pushed
the
fix/observer-stylesheet
branch
from
05d979c
to
e5584e7
Compare
| @@ -4,6 +4,7 @@ | |||
| "description": "record and replay the web", | |||
| "scripts": { | |||
| "test": "npm run bundle:browser && cross-env TS_NODE_CACHE=false TS_NODE_FILES=true mocha -r ts-node/register test/**/*.test.ts", | |||
| "test:watch": "PUPPETEER_HEADLESS=true npm run test -- --watch --watch-extensions js,ts", | |||
There was a problem hiding this comment.
can back this out if folks disagree but found it useful
aside, it doesnt recompile src/ and I couldn't figure out how to achieve that
There was a problem hiding this comment.
Could not get that done too...
Combine Mocha and Typescript is not as fluent as jest.
src/record/observer.ts
Outdated
| const insertRule = CSSStyleSheet.prototype.insertRule; | ||
| CSSStyleSheet.prototype.insertRule = function( | ||
| rule: string, | ||
| index?: number | undefined, |
There was a problem hiding this comment.
looks like index?: number is enough since ? already make type optional
| @@ -4,6 +4,7 @@ | |||
| "description": "record and replay the web", | |||
| "scripts": { | |||
| "test": "npm run bundle:browser && cross-env TS_NODE_CACHE=false TS_NODE_FILES=true mocha -r ts-node/register test/**/*.test.ts", | |||
| "test:watch": "PUPPETEER_HEADLESS=true npm run test -- --watch --watch-extensions js,ts", | |||
There was a problem hiding this comment.
Could not get that done too...
Combine Mocha and Typescript is not as fluent as jest.
|
@dcramer Thanks a lot! I would love to merge it after tweak some small changes. The test things can be done in the following PRs. |
|
@Yuyz0112 I fixed the type - were you asking me to pull the test:watch and other changes out? |
|
Nope, it's fine. |
This captures the insertRule and deleteRule actions on CSSStyleSheet, and wires them up to StyleSheetRule events in the recorder.