Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

set openssl dir and enable cross-compile #128

Closed
wants to merge 12 commits into from
Closed

Conversation

ifkb99
Copy link

@ifkb99 ifkb99 commented Mar 28, 2020

fix #96 along with including ipfs-http

@ifkb99
Copy link
Author

ifkb99 commented Mar 28, 2020

@aphelionz Should I keep trying directories that openssl may be in, or is there a better method?
https://github.com/ipfs-rust/rust-ipfs/pull/128/checks?check_run_id=541078376#step:11:205

@aphelionz
Copy link
Contributor

There's almost certainly be a better method, but I'm not yet familiar enough with the GH Actions runners to say - let me take a look at a few things. Also @hugomrdias posted some helpful links in Matrix: https://matrix.to/#/!JxzWpvsvfYuMHyUJiL:matrix.org/$t3B9RULiM-kSkPDR31xVtCiR4sAbeClHpteHijFgZyg?via=matrix.org&via=hielle.com&via=t2bot.io

@aphelionz
Copy link
Contributor

@ifkb99 Can you try:

  1. Adding this crate to http/Cargo.toml: https://crates.io/crates/openssl-probe
  2. Adding the line from openssl-probe's README to the main function in http/src/main.rs

@aphelionz
Copy link
Contributor

You'll also want to merge master in because of #124

@koivunej
Copy link
Collaborator

The windows test failure is one of the tests still racy to access the configuration file, the doctest failure is the flaky test fixed in #124 which would go away on rebasing to master.

Looks like you got the android build at least to work! Could leave the issue open for the mac ones since this is progress already! Though the android build apparently doesn't run tests, since tests currently guarded with cross == false. I don't see why tests could be be run on android, but now the separation from "cross[compiled]" will need to change to "apple" or something else.

@koivunej
Copy link
Collaborator

Rerunning the jobs just in case, looks like you merged back to your branch in the latest commit.

@aphelionz
Copy link
Contributor

I'd be ok with disabling the ios builds as we have before this, and then opening an issue to address them separately 👍

@koivunej
Copy link
Collaborator

Yeah, to recap:

  • exclude http on ios

I suggested running the tests on andoid but that of course wont work without a virtualization environment which I don't think we want to add here.

@aphelionz
Copy link
Contributor

Yes, I was agreeing

@aphelionz
Copy link
Contributor

@ifkb99 Can you disable the builds on the ios versions so we can get a green CI again? Then we can merge. Also, please comment here to add yourself to the roster: rs-ipfs/welcome#1

@aphelionz aphelionz mentioned this pull request Apr 1, 2020
@aphelionz
Copy link
Contributor

Looks like this needs a rebase and you should be good to go

@koivunej
Copy link
Collaborator

Closing this for inactivity.

@koivunej koivunej closed this Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partial builds on CI cross targets
3 participants