-
Notifications
You must be signed in to change notification settings - Fork 165
set openssl dir and enable cross-compile #128
Conversation
@aphelionz Should I keep trying directories that openssl may be in, or is there a better method? |
There's almost certainly be a better method, but I'm not yet familiar enough with the GH Actions runners to say - let me take a look at a few things. Also @hugomrdias posted some helpful links in Matrix: https://matrix.to/#/!JxzWpvsvfYuMHyUJiL:matrix.org/$t3B9RULiM-kSkPDR31xVtCiR4sAbeClHpteHijFgZyg?via=matrix.org&via=hielle.com&via=t2bot.io |
@ifkb99 Can you try:
|
You'll also want to merge master in because of #124 |
merged fixed set openssl dir and enable cross-compile
added openssl-probe added openssl-probe commit line
The windows test failure is one of the tests still racy to access the configuration file, the doctest failure is the flaky test fixed in #124 which would go away on rebasing to master. Looks like you got the android build at least to work! Could leave the issue open for the mac ones since this is progress already! Though the android build apparently doesn't run tests, since tests currently guarded with |
Rerunning the jobs just in case, looks like you merged back to your branch in the latest commit. |
I'd be ok with disabling the ios builds as we have before this, and then opening an issue to address them separately 👍 |
Yeah, to recap:
I suggested running the tests on andoid but that of course wont work without a virtualization environment which I don't think we want to add here. |
Yes, I was agreeing |
@ifkb99 Can you disable the builds on the ios versions so we can get a green CI again? Then we can merge. Also, please comment here to add yourself to the roster: rs-ipfs/welcome#1 |
Looks like this needs a rebase and you should be good to go |
Closing this for inactivity. |
fix #96 along with including ipfs-http