Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support extra arbitrary data at the end of console log #416

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Support extra arbitrary data at the end of console log #416

merged 1 commit into from
Jul 18, 2022

Conversation

mitar
Copy link
Contributor

@mitar mitar commented Feb 21, 2022

I use this to render a stack trace of the error in additional lines.

@mitar mitar mentioned this pull request Feb 23, 2022
Open
@dobegor
Copy link

dobegor commented Jun 6, 2022

@rs
Any objections to this?
It should not impact any existing users, but it will allow for more dev-friendly local use cases such as pretty stacktrace formatting, clickable stacktraces in IDEs from program output are very useful during debugging.

rs
rs reviewed Jul 16, 2022
View reviewed changes
console.go Show resolved Hide resolved
rs
rs requested changes Jul 18, 2022
View reviewed changes
console.go Outdated Show resolved Hide resolved
@rs rs merged commit 4099072 into rs:master Jul 18, 2022
pablitoc pushed a commit to nxcr-org/zerolog that referenced this pull request Apr 7, 2023
@mitar @pablitoc
Support extra arbitrary data at the end of console log (rs#416)
71cfddf
@mitar mitar mentioned this pull request Aug 3, 2023
Open
@max107 max107 mentioned this pull request Feb 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rs rs rs requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitar @dobegor @rs