Configurable Root url #82
Conversation
| private final String key; | ||
| private final String rootUrl; | ||
|
|
||
| public MandrillExportsApi(final String key, final String url) { |
There was a problem hiding this comment.
I wanted to modify the original constructor but since this is a public class with a public constructor that would break backwards compatibility which is why I chose overloading.
| @@ -22,6 +22,8 @@ | |||
| * @since Mar 17, 2013 | |||
| */ | |||
| public class MandrillApi { | |||
| public static final String rootUrl = "https://mandrillapp.com/api/1.0/"; | |||
There was a problem hiding this comment.
This is public because we need to default it here as well as in the other classes for backwards compatibility reasons. See below comment.
|
The |
| <version>1.3.2</version> | ||
| <groupId>commons-io</groupId> | ||
| <artifactId>commons-io</artifactId> | ||
| <version>2.5</version> <!-- 2.5 is the last version to support java 1.6 --> |
There was a problem hiding this comment.
I think this might be able to be switched to a test only dependency. It could also be a runtime dependency of the HttpClient though so I didn't change it.
| @@ -22,6 +22,8 @@ | |||
| * @since Mar 17, 2013 | |||
| */ | |||
| public class MandrillApi { | |||
| public static final String rootUrl = "https://mandrillapp.com/api/1.0/"; | |||
|
Thanks for the library! Any chances that version 0.0.8 including this fix will be released soon? |
|
it's in the pipeline. |
|
@rschreijer: Thank you for the release, really helps us a lot. |
I actually need this for security purposes. Also bumped versions of dependencies.