Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#83: Fixed error handling when send request fails with an exception. #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#83: Fixed error handling when send request fails with an exception. #84

wants to merge 1 commit into from

Conversation

thberger
Copy link

@thberger thberger commented Dec 7, 2017

Fixes #83 by

  • checking if response is null first
  • consuming the response entity quietly to avoid any new exception in the finally block which would hide the original exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thberger