Skip to content

Commit

Permalink
Bump yaml-cpp so it builds with Visual Studio 15.8 (envoyproxy#4182)
Browse files Browse the repository at this point in the history
Version 0.6.2 of yaml-cpp does not build when using Visual Studio 15.8,
for context see: jbeder/yaml-cpp#597

Updating to this commit fixes the issue.

Risk Level:
Low

Testing:
bazel test //test/... on Linux.

Signed-off-by: Sam Smith <[email protected]>
  • Loading branch information
sesmith177 authored and htuch committed Aug 16, 2018
1 parent 3d1325e commit e994c1c
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions ci/build_container/build_recipes/yaml-cpp.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@

set -e

VERSION=0.6.2
# Pin to this commit to pick up fix for building on Visual Studio 15.8
COMMIT=0f9a586ca1dc29c2ecb8dd715a315b93e3f40f79 # 2018-06-30

curl https://github.com/jbeder/yaml-cpp/archive/yaml-cpp-"$VERSION".tar.gz -sLo yaml-cpp-"$VERSION".tar.gz
tar xf yaml-cpp-"$VERSION".tar.gz
cd yaml-cpp-yaml-cpp-"$VERSION"
curl https://github.com/jbeder/yaml-cpp/archive/"$COMMIT".tar.gz -sLo yaml-cpp-"$COMMIT".tar.gz
tar xf yaml-cpp-"$COMMIT".tar.gz
cd yaml-cpp-"$COMMIT"

mkdir build
cd build
Expand Down

0 comments on commit e994c1c

Please sign in to comment.