This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
feat: upgradability using truffle plugin #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nduchak
approved these changes
Oct 8, 2020
| const { toBN, asciiToHex, padRight } = require('web3-utils') | ||
| const expect = require('chai').expect | ||
|
|
||
| const Staking = artifacts.require('Staking') | ||
| const StorageManager = artifacts.require('StorageManager') | ||
| const ERC20 = artifacts.require('MockERC20') | ||
|
|
||
| contract('Staking', ([staker, randomPerson]) => { | ||
| contract('Staking', ([randomPerson, staker]) => { |
There was a problem hiding this comment.
The plugins have still an open issue that is that you cannot specify the from address. It uses the accounts[0] from the accounts that Truffle provides. So I needed the first account to be the one Deploying the proxies. The easiest way was to revert the order to achieve that and have the one that deploys first.
There was a problem hiding this comment.
Ahh. Ok, make sense now). Thanks
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storageManagercontract for Upgradability. Uses the OpenZeppelin Upgrades Truffle Plugin.account[0]for deployment of the proxies).Closes #134