Skip to content

Commit

Permalink
Document deployment flags on UI and signer's Makefiles (#123)
Browse files Browse the repository at this point in the history
- Documented appFlags parameter on UI and signer
- Removed unused constant APP_LOAD_PARAMS
  • Loading branch information
italo-sampaio authored Jan 27, 2023
1 parent 5acf171 commit 62bd86b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
5 changes: 3 additions & 2 deletions ledger/src/signer/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ include $(BOLOS_SDK)/Makefile.defines
# Main app configuration
APPNAME = "RSK Sign"
APPVERSION = 3
APP_LOAD_PARAMS = --appFlags 0x00 $(COMMON_LOAD_PARAMS)
# No flags
APPFLAGS = 0x00
PROG = "app"

# Build configuration
Expand Down Expand Up @@ -111,7 +112,7 @@ load: bin/app.hex
--delete \
--targetId $(TARGET_ID) \
--fileName bin/$(PROG).hex \
--appFlags 0x0 \
--appFlags $(APPFLAGS) \
--appName $(APPNAME) \
--appVersion $(APPVERSION) \
--icon `cat icon.hex` \
Expand Down
4 changes: 3 additions & 1 deletion ledger/src/ui/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ endif
APPNAME = UX
APPVERSION = 3
VERSION = ux$(APPVERSION)
# APPLICATION_FLAG_BOLOS_UX | APPLICATION_FLAG_GLOBAL_PIN | APPLICATION_FLAG_BOLOS_SETTINGS
APPFLAGS = 0x248
# By default, don't build debug code.
DEBUG_BUILD = 0
################
Expand Down Expand Up @@ -219,7 +221,7 @@ load: bin/built
--delete \
--targetId $(TARGET_ID) \
--fileName bin/$(PROG).hex \
--appFlags 0x248 \
--appFlags $(APPFLAGS) \
--appName $(APPNAME) \
--appVersion $(APPVERSION) \
--icon `cat icon.hex` \
Expand Down

0 comments on commit 62bd86b

Please sign in to comment.