Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements on buffer comparison on UI unit tests #112

Merged
merged 4 commits into from
Jan 6, 2023
Merged

Improvements on buffer comparison on UI unit tests #112

merged 4 commits into from
Jan 6, 2023

Conversation

italo-sampaio
Copy link
Collaborator

  • Make sure we don't treat binary data as strings for data comparison
  • Use memcpy for implementation of set_apdu

@italo-sampaio
Improvements on buffer comparison on UI unit tests
0969d2c 
Make sure we don't treat binary data as strings for data comparison
amendelzon
amendelzon reviewed Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@amendelzon amendelzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Left some comments, maybe still some room for improvement?

ledger/src/ui/test/bootloader/test_bootloader.c Outdated Show resolved Hide resolved
ledger/src/ui/test/mock/assert_utils.h Outdated Show resolved Hide resolved
ledger/src/ui/test/onboard/test_onboard.c Outdated Show resolved Hide resolved
amendelzon
amendelzon approved these changes Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@amendelzon amendelzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@italo-sampaio italo-sampaio merged commit a885858 into master Jan 6, 2023
@italo-sampaio italo-sampaio deleted the fix/apdu-utils branch January 6, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amendelzon amendelzon amendelzon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@italo-sampaio @amendelzon