Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added static code analysis for ledger code #126

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

italo-sampaio
Copy link
Collaborator

  • Added clang static code analysis to signer
  • Added clang static code analysis to UI

Copy link
Collaborator

@amendelzon amendelzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I would also add the output of the analysis to the corresponding .gitignore.

- Added static code analysis to signer
- Added static code analysis to UI
- Added static-analisys folder to UI .gitignore
- Incidentally added a .gitignore specific to signer
@italo-sampaio italo-sampaio force-pushed the enhancement/84-static-code-analysis branch from 4c19eed to 434a037 Compare February 3, 2023 17:35
Copy link
Collaborator

@amendelzon amendelzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amendelzon amendelzon merged commit 8ca1eb2 into master Feb 3, 2023
@amendelzon amendelzon deleted the enhancement/84-static-code-analysis branch February 3, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants