Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed varint handling on BTC tx parser and RSK trie parser #128

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

amendelzon
Copy link
Collaborator

  • Handling partial varint parsing in BTC tx parsing
  • Fixing an issue when accumulating a varint raw data both in BTC tx parsing and RSK trie parsing
  • Added both BTC tx and trie unit test cases
  • Added an authorized signing test case to the signer tests
  • Incidentally fixing a log message format

- Handling partial varint parsing in BTC tx parsing
- Fixing an issue when accumulating a varint raw data both in BTC tx parsing and RSK trie parsing
- Added both BTC tx and trie unit test cases
- Added an authorized signing test case to the signer tests
- Incidentally fixing a log message format
Copy link
Collaborator

@italo-sampaio italo-sampaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amendelzon amendelzon merged commit c7a5620 into develop-3.0 Feb 8, 2023
@amendelzon amendelzon deleted the bugfix/btctx-partial-varint-handling branch February 8, 2023 18:46
amendelzon added a commit that referenced this pull request Feb 8, 2023
- Handling partial varint parsing in BTC tx parsing
- Fixing an issue when accumulating a varint raw data both in BTC tx parsing and RSK trie parsing
- Added both BTC tx and trie unit test cases
- Added an authorized signing test case to the signer tests
- Incidentally fixing a log message format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants