Added unit test for remaining admin modules #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
italo-sampaio
commented
Jun 15, 2022
italo-sampaio
commented
- Added unit tests for certificate.py
- Added unit tests for dongle_admin.py
- Added unit tests for rsk_client.py
- Improved execution time for admin unit tests
- Improved test coverage for attestation.py unit tests
- Added unit tests for certificate.py - Added unit tests for rsk_client.py - Added unit tests for dongle_admin.py - Refactor unit test for attestation.py - Optimized test_verify_attestation.py to use only one ecdsa library for keys manipulation - Reduced execution time for admin tests - Removed unnecessary check on certificate.py
italo-sampaio
force-pushed
the
feature/56-add-unit-test-for-remaining-admin-modules
branch
from
261d9e9
to
68aa174
Compare
amendelzon
requested changes
Jun 21, 2022
- Reverted changes on copyright year - Fixed test_attestation according to the code review - Changed generation of random hex string to a clearer form on certificate unit test - Fixed certificate unit tests to follow the right semantics - Created separete class for HSMCertificateElement unit test - Fixed rsk_client unit tests to avoid mocking os.random
amendelzon
reviewed
Jun 22, 2022
amendelzon
reviewed
Jun 22, 2022
amendelzon
approved these changes
Jun 22, 2022
amendelzon
deleted the
feature/56-add-unit-test-for-remaining-admin-modules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.