LockingCap Refactor Integration #2672

Following with the Bridge refactors, it is now time to refactor and remove the locking cap business logic from the Bridge. Create its package lockingcap with a Support, StorageProvider, and Constants classes. Since it will have its classes should remove from the variable names, lockingCap, to avoid being redundant.

Create the package lockingcap with an enum to hold the storage index key for locking cap value. Create a new enum LockingCapStorageIndexKey to contain the index key for the locking cap value in storage, remove it from BridgeStorageIndexKey, remove the. _KEY suffix, and rename to LOCKING_CAP.

Create an interface LockingCapStorageProvider under co.rsk.peg.lockingcap package. Include the signature of the methods mentioned above. Rename saveLockingCap to simply save

Create a new interface LockingCapSupport under the co.rsk.peg.lockingcap package. Copy the signature and javadoc for the methods: getLockingCap and increaseLockingCap.

Following the Bridge refactors, we already migrated the LockingCapConstants to their classes to break the high coupling LockingCap had with the Bridge objects, however, it’s missing add coverage, so we need to create Unit Tests to get reliability that your new code doesn't break existing functionality when a change is made to the application. Create Unit Tests for all methods in LockingCapConstants Create Test Cases for all Networks such as MainNet, TestNet, and RegTest.

Adding An Optional To Return Value getLockingCap() Method

Removing Arrays.stream From increaseAuthorizedKeys Variable and replacing it with Collections.unmodifiableList(Stream.of()

Following with the Bridge refactors, it is now time to refactor and remove locking cap logic from BridgeSupport class. Create LockingCapConstants in BridgeConstants.

Following with the Bridge refactors, it is now time to refactor and remove locking cap logic from Bridge objects to LockingCap objects. This time we need to add Locking Cap logic to BridgeSupportBuilder class. Add WhitelistSupport to BridgeSupportBuilder business logic. Rebasing Changes With Integration Branch Rebasing Changes With Integration Branch

- To avoid an NoSuchElementException trying to get the value from Optional.get() when is Optional.empty(), use orElse(null) method. Assigning a value to an instance variable - Assigning a value to an instance variable instead of return and after that assign. Improving readiness, readability and maintainability - Instead of enclosing in an IF a block of code, we ensure we have the RSKIP134 to execute the rest of the code.

After LockingCapSupport interface has been created, it is time to implement it. Create a new class LockingCapSupportImpl under co.rsk.peg.lockingcap package that implements the methods defined in LockingCapSupport interface. Take the implementation from BridgeSupport class, and move to this new class. Adapting implementation to stop using Optional and activation as an input at a Support level Getting back Optional since there's a case when we need to handle a null value Improving indentation Avoiding Null Pointer Exception - If it doesn't exist Locking Cap value, it must return false since RSKIP134 is not active. Assigning a value from an Optional to a new variable Rollback the changes on BridgeSupport

Update BridgeSupportFactory to create an instance of LockingCapSupport and pass it to BridgeSupport constructor. Fix code smells

After LockingCapSupport interface has been created, we’re going to use it on BridgeSupport. Adapt LockingCap methods in BridgeSupport.Use new interface created, LockingCapSupport, under co.rsk.peg.lockingcap package to create LockingCap behavior. Rebase Code Smell Removing Optional from getLockingCap() Method at a LockingCapSupport Level

…ort level Getting back Optional since there's a case when we need to handle a null value and adapting verifyLockDoesNotSurpassLockingCap to use getLockingCap() from LockingCapSupport Removing IF statement related to activation and adding a new validation to improve Readiness and Maintainability

Following the Bridge refactors, we already migrated the LockingCap processes to their classes to break the high coupling LockingCap had with the Bridge objects. After refactoring, showed up different issues in the tests and it is time to fix them. Fix LockingCapTest class, and improve if possible.

Following the Bridge refactors, we already migrated the LockingCap processes to their classes to break the high coupling LockingCap had with the Bridge objects. After refactoring, showed up different issues in the tests and it is time to fix them. Fix BridgeSupportAddSignatureTest class.

Following the Bridge refactors, we already migrated the LockingCap processes to their classes to break the high coupling LockingCap had with the Bridge objects. After refactoring, showed up different issues in the tests and it is time to fix them. Fix BridgeSupportIT class.

Following the Bridge refactors, we already migrated the LockingCap processes to their classes to break the high coupling LockingCap had with the Bridge objects. After refactoring, showed up different issues in the tests and it is time to fix them. Fix BridgeSupportRegisterBtcTransactionTest class.

Following the Bridge refactors, we already migrated the LockingCap processes to their classes to break the high coupling LockingCap had with the Bridge objects. After refactoring, showed up different issues in the tests and it is time to fix them. Fix BridgeStorageProviderTest class. Get rid of LockingCap test methods.

Following the Bridge refactors, we already migrated the LockingCap processes to their classes to break the high coupling LockingCap had with the Bridge objects. After refactoring, showed up different issues in the tests and it is time to fix them. Fix the BridgeSupportTest class.

Following the Bridge refactors, we already migrated the LockingCap processes to their classes to break the high coupling LockingCap had with the Bridge objects. After refactoring, showed up different issues in the tests and it is time to fix them. Fix the PowpegMigrationTest class. Get rid of setting the LockingCap since it is not mandatory in the test. From now on, the test will use the LockingCap default value, i.e., the LockingCapConstants.initialValue().

Following the Bridge refactors, we already migrated the LockingCap processes to their classes to break the high coupling LockingCap had with the Bridge objects. After refactoring, showed up different issues in the tests and it is time to fix them. Fix the BridgeSupportTest class.

Following the Bridge refactors, we already migrated the LockingCap objects to their classes to break the high coupling LockingCap had with the Bridge objects, however, it’s missing add coverage, so we need to create Unit Tests to get reliability that your new code doesn't break existing functionality when a change is made to the application. - Create tests for LockingCapStorageProviderImpl. Keep Came Case In the Test Names Adding a blank line at the end of the file Getting Readiness To the Code Adding A New Test Case Improving Method Names Improving Variable Name Improving Method Names And Expected Variable Names Improving Method Names Improving Method Names Moving from place Papyrus200 tests Improving Comments Improving Assertions

Following the Bridge refactors, we already migrated the LockingCapConstants to their classes to break the high coupling LockingCap had with the Bridge objects, however, it’s missing add coverage, so we need to create Unit Tests to get reliability that your new code doesn't break existing functionality when a change is made to the application. - Create Unit Tests for all methods in LockingCapSupportImpl. - Apply different tests for all scenarios. Activate the wasabi100 Fork to activate and deactivate RSKIPs necessaries in the Test Changing Method Name Changing Method Name Changing Method Names Keep Camel Case In Test Names Removing Blank Line Improving Name Method Improving Name Method Improving Name Method Improving Name Method Improving Name Method Adding A Blank Line Improving Variable Name Improving Method Names Use getLockingCap method from LockingCapSupport in Save Tests Improving Variable Name to maxLockingCapVoteValueAllowed

Following the Bridge refactors, we already migrated the LockingCapConstants to their classes to break the high coupling LockingCap had with the Bridge objects, however, it’s missing add coverage, so we need to create Unit Tests to get reliability that your new code doesn't break existing functionality when a change is made to the application. - Create Unit Tests for all methods LockingCap-related in BridgeSupport. Setting private modifier to a constant variable Adding New Test Case - Adding new getLockingCap_whenLockingCapIsEmpty_ReturnNull test case. Keep Camel Case In Test Names Improving assertion to avoid compare instance but values

Fix registerBtcTransaction_after_RSKIP134_activation_sends_above_lockingcap test Rollback imports and moved `bridgeSupportBuilder.withLockingCapSupport` to the end before the build

Following the Bridge refactors, we already migrated the LockingCap processes to their classes to break the high coupling LockingCap had with the Bridge objects. Please move the business logic related to the zero-negative LockingCap value from Bridge.java to LockingCapSupportImpl.java. This way, decouple the process and get all LockingCap business logic, in the LockingCapSupport object. Adding log for Zero - Negative LockingCap Value Refactoring increaseLockingCap tests in BridgeTest

- Using in LockingCap objects LockingCapIllegalArgumentException. - In Bridge objects VMException. Created INCREASE_LOCKING_CAP_LOG_TAG constant to avoid String repetition Bank line to improve readability When No Arguments Test Case, replaced encodeSignature with encodeArguments method Created a message string to avoid repetition Avoiding String Repetition Removed Unused Import Improving Log Message Improving Log Message for maxLockingCapVoteValueAllowed Case Improving Exception Handling for increaseLockingCap in Bridge objects Use ActivationConfigsForTest.all() instead of papyrus200() - Use ActivationConfigsForTest.all() instead of papyrus200() since it's not needed a specific fork in the most of the test cases Improving Logger Messages Improving Logger Messages

Get rid of getInstance in BridgeRegTestConstants Left the changes on LockingCapTest as it was early

….java

Add coverage for getFeePerKbConstants, getWhitelistConstants, and getFederationConstants in BridgeConstants. Use wildcard imports Get rid of assertEquals in new Unit Tests

Following the Bridge refactors, we already migrated the LockingCapConstants to their classes to break the high coupling LockingCap had with the Bridge objects, however, it’s missing add coverage, so we need to create Unit Tests to get reliability that your new code doesn't break existing functionality when a change is made to the application. Create the Integration Test for the whole process related to LockingCap.

Remove unused import

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LockingCap Refactor Integration #2672

LockingCap Refactor Integration #2672

Commits on Aug 20, 2024