Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some issues on RIT workflow #2724

Merged
merged 14 commits into from
Sep 24, 2024
Merged

Conversation

fmacleal
Copy link
Contributor

@fmacleal fmacleal commented Sep 12, 2024

Issues fixed:
1 - Remove the trigger on push for master and *-rc -> we don't need that anymore since we are running it for every commit on PRs against these branches.
2 - Send the status of the execution to slack
3 - Solve the issue that the status of an execution triggered via workflow doesn't update the PR status.
And if we need to use a different branch for RIT, Powpeg and RIT in the PR, it won't change the status to
green after the workflow_dispatch execution -> We will do that adding a parsing on the description, looking
for the branch that need to be used for that PR. If there is no branch configured on the description, we will
try to use the default one.

Branches to be used by RIT:
fed:vovchyk/jackson-ver-bump
rskj:vovchyk/jackson-ver-bump

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@fmacleal fmacleal force-pushed the fix/solving_issues_rit_workflow branch 30 times, most recently from e8d0d70 to 21bd4af Compare September 13, 2024 15:28
.github/workflows/rit.yml Outdated Show resolved Hide resolved
.github/workflows/rit.yml Outdated Show resolved Hide resolved
lucasvuotto
lucasvuotto previously approved these changes Sep 19, 2024
.github/workflows/rit.yml Outdated Show resolved Hide resolved
.github/workflows/rit.yml Outdated Show resolved Hide resolved
@fmacleal fmacleal force-pushed the fix/solving_issues_rit_workflow branch from 8bb54ac to 9c97b9d Compare September 20, 2024 12:29
@fmacleal fmacleal force-pushed the fix/solving_issues_rit_workflow branch 5 times, most recently from bd6e50e to 493afe5 Compare September 23, 2024 16:17
@fmacleal fmacleal force-pushed the fix/solving_issues_rit_workflow branch from 493afe5 to 0d91f89 Compare September 23, 2024 17:40
Copy link

sonarcloud bot commented Sep 24, 2024

@Vovchyk Vovchyk merged commit 6c970ff into master Sep 24, 2024
10 checks passed
@Vovchyk Vovchyk deleted the fix/solving_issues_rit_workflow branch September 24, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants