Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MaxInitcodeSize): fix NPE in transactionCost() method #2744

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

Vovchyk
Copy link
Contributor

@Vovchyk Vovchyk commented Sep 20, 2024

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

fmacleal
fmacleal previously approved these changes Sep 20, 2024
Copy link
Contributor

@fmacleal fmacleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch!

@Vovchyk Vovchyk force-pushed the vovchyk/initcode-limit-feature-fix branch from fd22722 to 642406b Compare September 25, 2024 08:05
Copy link

sonarcloud bot commented Sep 25, 2024

@Vovchyk Vovchyk merged commit 29408dc into master Sep 25, 2024
10 checks passed
@Vovchyk Vovchyk deleted the vovchyk/initcode-limit-feature-fix branch September 25, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants