Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of Transient Storage Opcodes #2778

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

fmacleal
Copy link
Contributor

@fmacleal fmacleal commented Oct 1, 2024

This PR aims to implements the RSKIP-446 that handles the transient storage opcodes defined int he RSKIP-446, which aims to be compatible with EIP-1153 from Ethereum.

The PR still in draft mode because some tests need to be fixed and added.

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@@ -984,6 +984,10 @@
getStorage().addStorageRow(getOwnerRskAddress(), keyWord, valWord);
}

public void transientStorageSave(DataWord key, DataWord address) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'key' is never used.
@@ -984,6 +984,10 @@
getStorage().addStorageRow(getOwnerRskAddress(), keyWord, valWord);
}

public void transientStorageSave(DataWord key, DataWord address) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'address' is never used.
@@ -1094,6 +1098,10 @@
return getStorage().getStorageValue(getOwnerRskAddress(), key);
}

public void transientStorageLoad(DataWord address, DataWord key, DataWord value) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'address' is never used.
@@ -1094,6 +1098,10 @@
return getStorage().getStorageValue(getOwnerRskAddress(), key);
}

public void transientStorageLoad(DataWord address, DataWord key, DataWord value) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'key' is never used.
@@ -1094,6 +1098,10 @@
return getStorage().getStorageValue(getOwnerRskAddress(), key);
}

public void transientStorageLoad(DataWord address, DataWord key, DataWord value) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'value' is never used.
@fmacleal fmacleal force-pushed the fmacleal/addition_transient_storage_opcodes branch from d6dc804 to 8892bf3 Compare October 14, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants