Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes block() in MetadataPushRequesterMono/FnfRequesterMono #1044

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

OlegDokuka
Copy link
Member

closes #1033. Supersedes #1034

Signed-off-by: Oleh Dokuka [email protected]
Signed-off-by: Oleh Dokuka [email protected]

Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Copy link
Contributor

@rstoyanchev rstoyanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

However, considering the description under #1034:

faulty implementation of the block method, which in turn was a near-duplicate of the subscribe method. Mono's implementation of the block methods already delegate to subscribe in a safe way, as it seems, so there seems to be no obvious (documented) reason why the block method needs to be overridden.

It would be good to add to the Java doc of those block methods that explains the reason they are there.

Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
@OlegDokuka OlegDokuka changed the title fixes block() in MetadataPushRequesterMono fixes block() in MetadataPushRequesterMono/FnfRequesterMono Mar 28, 2022
@OlegDokuka OlegDokuka merged commit 9a504a8 into master Mar 28, 2022
@OlegDokuka OlegDokuka deleted the bugfix/1033 branch March 28, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetaData Push rejects meta data in Payload when using block()
2 participants