Move RSocketFactory implementation to core sub-package to avoid dependencies from top-level package #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencergibb
approved these changes
Apr 8, 2020
OlegDokuka
requested changes
Apr 8, 2020
rsocket-core/src/main/java/io/rsocket/core/DefaultClientRSocketFactory.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/main/java/io/rsocket/core/DefaultClientRSocketFactory.java
Show resolved
Hide resolved
rsocket-core/src/main/java/io/rsocket/core/DefaultServerRSocketFactory.java
Outdated
Show resolved
Hide resolved
rstoyanchev
force-pushed
the
core-package
branch
from
99b0675
to
59262bd
Compare
rstoyanchev
added a commit
to rstoyanchev/rsocket-java
that referenced
this pull request
Apr 9, 2020
See rsocketgh-770 Signed-off-by: Rossen Stoyanchev <[email protected]>
This commit extracts interfaces for ClientRSocketFactory, ServerRSocketFactory, and ConnectionSetupPayload, and moves the implementations into a sub-package with no references to it from the top-level package. This removes a large package cycle with io.rsocket at the center of everything since it currently contains both high level abstractions that (accessed by everything), as well as core protocol implementations classes (accessing everything). The refactoring is functionally neutral and backwards compatible. Signed-off-by: Rossen Stoyanchev <[email protected]>
See rsocketgh-770 Signed-off-by: Rossen Stoyanchev <[email protected]>
rstoyanchev
force-pushed
the
core-package
branch
from
82a412e
to
608b952
Compare
OlegDokuka
added
refactorings
rstoyanchev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The top-level
io.rsocketpackage is at the center of a large package cycle because it contains both high level abstractions, accessed by everything, and also core protocol implementations classes that access everything:This change extracts interfaces for
ClientRSocketFactory,ServerRSocketFactory, andConnectionSetupPayload, and moves the core implementations into a sub-package without references to it from the top-level package. After the changes:This isn't the end of it but it helps quite a bit while keeping the refactoring functionally neutral and backwards compatible.