Update URL of RSocket Demo Client in Readme #939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
approved these changes
Oct 3, 2020
The URL has changed, see: https://rsocket-demo.herokuapp.com Signed-off-by: Michael Hunger <[email protected]>
…eactor dependency Signed-off-by: Michael Hunger <[email protected]>
|
Also added the M2 and the repository spring-milestone for reactor to the readme fixes #940 |
Signed-off-by: Michael Hunger <[email protected]>
OlegDokuka
reviewed
Oct 3, 2020
| @@ -40,6 +42,7 @@ Example: | |||
| ```groovy | |||
| repositories { | |||
| maven { url 'https://oss.jfrog.org/oss-snapshot-local' } | |||
| maven { url 'https://repo.spring.io/milestone' } | |||
There was a problem hiding this comment.
Suggested change
| maven { url 'https://repo.spring.io/milestone' } | |
| maven { url 'https://repo.spring.io/snapshot' } |
We usually depend on the snapshots or reactor, thus if such occasion happens, it is better to specify a snapshot repo
There was a problem hiding this comment.
Also, this does not fix #940 since this section is related to the snapshots, but M1 now specified as a release one, so I would suggest adding a similar section for release and keep it until we have a GA for 1.1.0
|
This should be addressed now. Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL has changed, see: https://rsocket-demo.herokuapp.com