Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provides request intercepting api #944

Merged
merged 3 commits into from
Oct 16, 2020

Conversation

OlegDokuka
Copy link
Member

This PR provides a RequestInterceptor interface API and an appropriate implementation in every RequestOperator implementation.

This interceptor is a building block to build Stats/Metrics tracking without providing a wrapper for every call.

Signed-off-by: Oleh Dokuka [email protected]

@OlegDokuka OlegDokuka added this to the 1.1 RC2 milestone Oct 12, 2020
@OlegDokuka OlegDokuka marked this pull request as draft October 12, 2020 16:22
@OlegDokuka OlegDokuka force-pushed the enhancement/request-intereptor-feature branch from eeaac34 to 0b108ea Compare October 12, 2020 16:35
Copy link
Contributor

@rstoyanchev rstoyanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, some comments below.

@OlegDokuka OlegDokuka force-pushed the enhancement/request-intereptor-feature branch from 0b108ea to cc4595b Compare October 16, 2020 07:45
@OlegDokuka OlegDokuka marked this pull request as ready for review October 16, 2020 07:47
@OlegDokuka OlegDokuka force-pushed the enhancement/request-intereptor-feature branch from cc4595b to 168450e Compare October 16, 2020 20:26
@OlegDokuka OlegDokuka merged commit 1398cba into master Oct 16, 2020
@OlegDokuka OlegDokuka deleted the enhancement/request-intereptor-feature branch October 16, 2020 20:45
@OlegDokuka OlegDokuka modified the milestones: 1.1 RC2, 1.1.0 Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants