provides reworked AeronTransport implementation #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
reviewed
Jan 2, 2021
| @@ -11,7 +11,7 @@ | |||
| protected UnboundedProcessor sender = new UnboundedProcessor(); | |||
|
|
|||
| public BaseDuplexConnection() { | |||
| onClose.doFinally(s -> doOnClose()).subscribe(); | |||
| onClose.subscribe(null, t -> doOnClose(), this::doOnClose); | |||
There was a problem hiding this comment.
unrelated, non-blocking. What's the plan with the deprecation? reactor/reactor-core#2431 (comment)
Should onClose be updated?
There was a problem hiding this comment.
Yeah. I will do that in a separate PR
yschimke
reviewed
Jan 2, 2021
| @@ -11,7 +11,7 @@ | |||
| protected UnboundedProcessor sender = new UnboundedProcessor(); | |||
|
|
|||
| public BaseDuplexConnection() { | |||
| onClose.doFinally(s -> doOnClose()).subscribe(); | |||
| onClose.subscribe(null, t -> doOnClose(), this::doOnClose); | |||
There was a problem hiding this comment.
Does this still run for cancellation?
There was a problem hiding this comment.
I dont think it should at all. In this case, we wait for onError or onComplete
yschimke
reviewed
Jan 2, 2021
yschimke
reviewed
Jan 2, 2021
rsocket-transport-aeron/src/main/java/io/rsocket/transport/aeron/AeronChannelAddress.java
Show resolved
Hide resolved
yschimke
reviewed
Jan 2, 2021
rsocket-transport-aeron/src/main/java/io/rsocket/transport/aeron/AeronClientTransport.java
Outdated
Show resolved
Hide resolved
yschimke
reviewed
Jan 2, 2021
rsocket-transport-aeron/src/main/java/io/rsocket/transport/aeron/AeronClientTransport.java
Outdated
Show resolved
Hide resolved
yschimke
reviewed
Jan 2, 2021
| .subscribe( | ||
| null, | ||
| __ -> { | ||
| synchronized (activeConnections) { |
There was a problem hiding this comment.
Can this duplication be improved by using doOnTerminate or doFinally?
yschimke
reviewed
Jan 2, 2021
rsocket-transport-aeron/src/main/java/io/rsocket/transport/aeron/AeronServerTransport.java
Outdated
Show resolved
Hide resolved
|
Low value drive by review of a draft PR. Mainly me trying to learn from the PR. |
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
…on/AeronClientTransport.java Co-authored-by: Yuri Schimke <[email protected]>
…on/AeronServerTransport.java Co-authored-by: Yuri Schimke <[email protected]>
uncomments largePayload tests Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]> Signed-off-by: Oleh Dokuka <[email protected]> Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]> Signed-off-by: Oleh Dokuka <[email protected]> Signed-off-by: Oleh Dokuka <[email protected]>
OlegDokuka
force-pushed
the
enhancement/aeron-support
branch
from
0753b6e
to
6aa3d8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleh Dokuka [email protected]