Remove shared_context_metadata_behavior config option and make apply_to_host_groups the default #2834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
force-pushed
the
apply-to-host-groups
branch
from
ca9ef62
to
bd3ccc6
Compare
pirj
force-pushed
the
apply-to-host-groups
branch
from
bd3ccc6
to
c8c8482
Compare
JonRowe
approved these changes
Dec 30, 2020
pirj
changed the title
pirj
force-pushed
the
apply-to-host-groups
branch
from
c8c8482
to
72e4fd9
Compare
pirj
added a commit
to rspec/rspec-rails
that referenced
this pull request
Jan 9, 2021
panSarin
pushed a commit
to 2N-IT/rspec-rails
that referenced
this pull request
Feb 19, 2021
pirj
added a commit
that referenced
this pull request
Mar 1, 2021
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 19, 2021
…ost-groups Remove shared_context_metadata_behavior config option and make apply_to_host_groups the default --- This commit was imported from rspec/rspec-core@23bbc51.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 19, 2021
Fixes rspec/rspec-core#2775 Related: - rspec/rspec-core#2834 - rspec/rspec-core#2832 - rspec/rspec-core#1762 --- This commit was imported from rspec/rspec-core@361e521.
pirj
added a commit
to rubocop/rubocop-rspec
that referenced
this pull request
Jul 9, 2022
Starting from RSpec 4, the implicit shared context inclusion, when a shared context would have been included to an example if the example has matching metadata, is not the case anymore. See: - rspec/rspec-core#2834 - rspec/rspec-core#2832 - rspec/rspec-core#2878
pirj
added a commit
to rubocop/rubocop-rspec
that referenced
this pull request
Jul 9, 2022
Starting from RSpec 4, the implicit shared context inclusion, when a shared context would have been included to an example if the example has matching metadata, is not the case anymore. See: - rspec/rspec-core#2834 - rspec/rspec-core#2832 - rspec/rspec-core#2878
pirj
added a commit
to rubocop/rubocop-rspec
that referenced
this pull request
Jul 9, 2022
Starting from RSpec 4, the implicit shared context inclusion, when a shared context would have been included to an example if the example has matching metadata, is not the case anymore. See: - rspec/rspec-core#2834 - rspec/rspec-core#2832 - rspec/rspec-core#2878
pirj
added a commit
to rubocop/rubocop-rspec
that referenced
this pull request
Jul 10, 2022
Starting from RSpec 4, the implicit shared context inclusion, when a shared context would have been included to an example if the example has matching metadata, is not the case anymore. See: - rspec/rspec-core#2834 - rspec/rspec-core#2832 - rspec/rspec-core#2878
Merged
5 tasks
pirj
added a commit
to rubocop/rubocop-capybara
that referenced
this pull request
Dec 29, 2022
Starting from RSpec 4, the implicit shared context inclusion, when a shared context would have been included to an example if the example has matching metadata, is not the case anymore. See: - rspec/rspec-core#2834 - rspec/rspec-core#2832 - rspec/rspec-core#2878
ydah
pushed a commit
to rubocop/rubocop-factory_bot
that referenced
this pull request
Apr 13, 2023
Starting from RSpec 4, the implicit shared context inclusion, when a shared context would have been included to an example if the example has matching metadata, is not the case anymore. See: - rspec/rspec-core#2834 - rspec/rspec-core#2832 - rspec/rspec-core#2878
ydah
pushed a commit
to rubocop/rubocop-rspec_rails
that referenced
this pull request
Mar 27, 2024
Starting from RSpec 4, the implicit shared context inclusion, when a shared context would have been included to an example if the example has matching metadata, is not the case anymore. See: - rspec/rspec-core#2834 - rspec/rspec-core#2832 - rspec/rspec-core#2878
ydah
pushed a commit
to rubocop/rubocop-rspec_rails
that referenced
this pull request
Mar 27, 2024
Starting from RSpec 4, the implicit shared context inclusion, when a shared context would have been included to an example if the example has matching metadata, is not the case anymore. See: - rspec/rspec-core#2834 - rspec/rspec-core#2832 - rspec/rspec-core#2878
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2832
Depends on:
shared_context_metadata_behaviorfrom spec helpersshouldand globally-exposed DSL