Remove deprecated :example_group example metadata sub-hash
#2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JonRowe I would really appreciate your help here. Specs are failing and I guess I did something wrong. |
This comment has been minimized.
This comment has been minimized.
pirj
force-pushed
the
remove-example_group-subhash
branch
from
ac3ae2d
to
e1dfc63
Compare
pirj
changed the title
pirj
changed the title
:example_group example metadata sub-hash
pirj
changed the title
:example_group example metadata sub-hash:example_group example metadata sub-hash
pirj
force-pushed
the
remove-example_group-subhash
branch
from
e1dfc63
to
d7603e5
Compare
pirj
commented
Feb 10, 2021
JonRowe
reviewed
Feb 10, 2021
Changelog.md
Outdated
| @@ -13,6 +13,8 @@ Breaking Changes: | |||
| * Raise on usage of metadata on suite-level scopes. (Phil Pirozhkov, #2849) | |||
| * Raise an error when `fail_fast` is configured with | |||
| an unsupported value. (Phil Pirozhkov, #2849) | |||
| * Remove deprecated exposition of example group's metadata | |||
| in example's metadata `:example_group` subhash. (Phil Pirozhkov, #2851) | |||
There was a problem hiding this comment.
This needs rewording but I havent had enough coffee yet to process how.
|
This looks good to me overall |
pirj
force-pushed
the
remove-example_group-subhash
branch
from
18e12b3
to
762934a
Compare
JonRowe
reviewed
Feb 10, 2021
JonRowe
approved these changes
Feb 10, 2021
pirj
force-pushed
the
remove-example_group-subhash
branch
from
eb5c579
to
9daaf1f
Compare
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 19, 2021
…mple_group-subhash Remove deprecated `:example_group` example metadata sub-hash --- This commit was imported from rspec/rspec-core@0ea90bb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: