Add --only-pending CLI option
#3068
Conversation
| @@ -2196,15 +2219,27 @@ def run_suite_hooks(hook_description, hooks) | |||
| end | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
Gathering the intersection of files here is where I found it getting messy. Specifically if there were ever to be more flags similar to these set, it might be worth extracting some of this functionality.
| def configure_only_pending(options) | ||
| options[:only_pending] = true | ||
| add_tag_filter(options, :inclusion_filter, :last_run_status, 'pending') | ||
| end |
There was a problem hiding this comment.
These could probably be collapsed to a configure_only(options, :pending) configure_only(options, :failures) type call
There was a problem hiding this comment.
@JonRowe , as a tradeoff here, I'm supplying three arguments. This accounts for the difference between 'failures' and 'failed'. If the terms were the same like 'pending', then I could just construct the symbol like
options["only_#{type}"] = true
My other thought was some sort of constant mapping.
| @@ -2196,15 +2219,27 @@ def run_suite_hooks(hook_description, hooks) | |||
| end | |||
| end | |||
|
|
|||
| def get_files_to_run(paths) | |||
There was a problem hiding this comment.
@JonRowe , I was thinking the method #get_files_to_run was getting too large, so I wanted to break it up. Maybe that's premature, since nothing else calls #get_files.
As requested on issue #3066, this work adds the CLI option filter
--only-pending. This is similar to--only-failures.If
example_status_persistence_file_pathis not configured, it will fail with a message.If both this new flag and
--only-failuresare set, it will fail with a message.