For discussion: be explicit about JRuby opts #115
Conversation
|
Thanks. I used the |
| export JRUBY_OPTS="${JRUBY_OPTS} -X-C" # disable JIT since these processes are so short lived | ||
| # If JRUBY_OPTS isn't set, use these. | ||
| # see http://docs.travis-ci.com/user/ci-environment/ | ||
| export JRUBY_OPTS=${JRUBY_OPTS:---server -Xcompile.invokedynamic=false"} |
There was a problem hiding this comment.
It appears that you're change here is invalid bash, as the PRs I opened with your changes are all failing with a syntax error:
script/functions.sh: line 90: syntax error near unexpected token `)'
Any ideas how your change could have caused that?
There was a problem hiding this comment.
Thanks @JonRowe That is deeply embarrassing. Reminds me of the calculus exam I near got 100% on, but, on one of the questions, after solving some integrals, summed 1 and -1 to get 2, or something ridiculous like that.
There was a problem hiding this comment.
It's fine we all do it especially when we're not running the thing we're changing directly. The amount of times I commit 1.9 hash syntax into our specs then wonder why the build breaks ;)
https://travis-ci.org/rspec/rspec-support/jobs/45770207#L544 Per http://docs.travis-ci.com/user/ci-environment/ Use -Xcompat.version=2.0 per `jruby --properties` as `--2.0` wasn't being respected
Remove vestigial JRuby config
bf4
force-pushed
the
working_jruby_opts
branch
from
408779e
to
4834dc7
Compare
|
OK, force pushed updates to all the PRs for all repos. BTW, thanks for looking into this. I had noticed the jruby warnings but wasn't sure how to fix them! |
|
@myronmarston I had thought Travis was fixing the JRuby-head build cext.enabled warnings, but turns out that was something else. One of us will have to check if there's an open issue for this. cc @headius @enebo fwiw |
|
Thanks, @bf4. The rspec-mocks build passes on JRuby head now! |
For discussion: be explicit about JRuby opts
See https://travis-ci.org/troessner/reek/jobs/67756300#L297-L307 This is really only an issue on JRUBY-HEAD where cext.enabled property no longer exists. ```ruby expected: "" got: "jruby: warning: unknown property jruby.cext.enabled\njruby: warning: unknown property jruby.cext.enabled\njruby: warning: unknown property jruby.cext.enabled\njruby: warning: unknown property jruby.cext.enabled\n" (compared using ==) Diff: @@ -1 +1,5 @@ +jruby: warning: unknown property jruby.cext.enabled +jruby: warning: unknown property jruby.cext.enabled +jruby: warning: unknown property jruby.cext.enabled +jruby: warning: unknown property jruby.cext.enabled (RSpec::Expectations::ExpectationNotMetError) ./features/step_definitions/reek_steps.rb:58:in `/^it reports no errors$/' features/configuration_loading.feature:29:in `Then it reports no errors' ``` ref: rspec/rspec-dev#115 ```ru
This is really only an issue on JRUBY-HEAD where
cext.enabled property no longer exists.
https://travis-ci.org/rspec/rspec-core/jobs/50010459#L166