Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use RSpec.configure to use the matcher DSL #1048

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't use RSpec.configure to use the matcher DSL #1048

wants to merge 1 commit into from

Commits on Mar 2, 2018

  1. Don't use RSpec.configure to use the matcher DSL 

    rspec-expectations shouldn't have knowledge of how to hook itself into
rspec-core. rspec-core already includes the `RSpec::Matchers` module in
example groups, so just including the module there (in addition to
extending it) is enough to provide it to rspec-core, even if rspec-core
hasn't been loaded yet and is loaded after rspec-expectations.

Fixes rspec#1045.
    @alyssais
    alyssais committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    ce891f1 View commit details
    Browse the repository at this point in the history