Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ill-defined warn expectation #1244

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Fix ill-defined warn expectation #1244

merged 1 commit into from
Dec 18, 2020

Conversation

pirj
Copy link
Member

@pirj pirj commented Dec 18, 2020 •
edited
Loading 

-["include {:message => (match /legacy\\s+RSpec\\s+matcher/), :call_site => (include \"/home/runner/work/rspec-support/rspec-expectations/spec/rspec/matchers/legacy_spec.rb:31\")}"]
       +[{:message=>
       +   "#<#<Class:0x000055fcd6e44840>:0x000055fcd6e52bc0> implements a legacy RSpec matcher\nprotocol. For the current protocol you should expose the failure messages\nvia the `failure_message` and `failure_message_when_negated` methods.\n(Used from /home/runner/work/rspec-support/rspec-expectations/spec/rspec/matchers/legacy_spec.rb:31:in `block (4 levels) in <module:Matchers>')\n",
       +  :type=>"legacy_matcher"}]

See rspec/rspec-support#451

@pirj
Fix ill-defined warn expectation
216db53 
        -["include {:message => (match /legacy\\s+RSpec\\s+matcher/), :call_site => (include \"/home/runner/work/rspec-support/rspec-expectations/spec/rspec/matchers/legacy_spec.rb:31\")}"]
       +[{:message=>
       +   "#<#<Class:0x000055fcd6e44840>:0x000055fcd6e52bc0> implements a legacy RSpec matcher\nprotocol. For the current protocol you should expose the failure messages\nvia the `failure_message` and `failure_message_when_negated` methods.\n(Used from /home/runner/work/rspec-support/rspec-expectations/spec/rspec/matchers/legacy_spec.rb:31:in `block (4 levels) in <module:Matchers>')\n",
       +  :type=>"legacy_matcher"}]

See rspec/rspec-support#452
@pirj pirj self-assigned this Dec 18, 2020
@pirj pirj requested a review from JonRowe December 18, 2020 12:39
@pirj pirj mentioned this pull request Dec 18, 2020
Merged
@JonRowe JonRowe merged commit 4409a7a into 4-0-dev Dec 18, 2020
@JonRowe JonRowe deleted the fix-deprecation-expectation branch December 18, 2020 14:51
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 19, 2021
@JonRowe
[expectations] Merge pull request rspec/rspec-expectations#1244 from …
efa861c 
…rspec/fix-deprecation-expectation

Fix ill-defined warn expectation

---
This commit was imported from rspec/rspec-expectations@4409a7a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonRowe JonRowe Awaiting requested review from JonRowe

Assignees

@pirj pirj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pirj @JonRowe