Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up the ContainExactly matcher #1333

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Speed up the ContainExactly matcher #1333

wants to merge 3 commits into from

Commits on Oct 29, 2021

  1. Speed up the ContainExactly matcher 

    Speed up the ContainExactly matcher by pre-emptively matching up corresponding elements in the expected and actual arrays.

This addresses rspec#1006, rspec#1161.

This PR is a collaboration between me and @genehsu based on
a couple of our earlier PRs and discussion that resulted:
1) rspec#1325
2) rspec#1328

Co-authored-by: Gene Hsu (@genehsu)
    @bclayman-sq
    bclayman-sq committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    56ba3e4 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2021

  1. Decrease number of elements in actual, expected to 1,000

    @bclayman-sq
    bclayman-sq committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    fee2c54 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2021

  1. Incorporate feedback: Add benchmark comment; use named subjects where… 

    … possible
    @bclayman-sq
    bclayman-sq committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    7dc4b1e View commit details
    Browse the repository at this point in the history