Work around bug in 1.8.7's Method#to_proc.
#641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I considered keeping the `Method#to_proc` implementation for other rubies (1.9+), assuming it would be faster, but benchmarks reveal it is in fact _slower_.
|
This LGTM. Does it need a changelog entry? |
myronmarston
added a commit
that referenced
this pull request
Aug 28, 2014
Work around bug in 1.8.7's `Method#to_proc`.
No, the bug this fixes has never been in a released version of RSpec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I considered keeping the
Method#to_procimplementationfor other rubies (1.9+), assuming it would be faster,
but benchmarks reveal it is in fact slower.
This fixes the failure @samphippen has been running into in rspec/rspec-mocks#751.