-
-
Notifications
You must be signed in to change notification settings - Fork 358
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add a sketch implementation of args diffing
Related #434. This uses the differ that is now in RSpec support to perform argument diffing when arguments don't match. Things worth noting/still to do: * Special case behaviour needs to be added for the no arguments matcher and the any arguments matcher, at the moment something like this: @@ -1,2 +1,2 @@ -[#<RSpec::Mocks::ArgumentMatchers::NoArgsMatcher:0x000001024ec728>] +[{:bees=>:foo}] gets printed, and that's obviously not great. * Need to work out what to do in the "similar args" case where there are potientially multiple calls. I think the best thing to do would be to would be to only diff if there's one call. There's some refactoring that could be done here but I want to finish implementing the "similar args" implementation before I do that so that I'm sure that I'm refactoring the right thing.
- Loading branch information
Sam Phippen
committed
Sep 4, 2014
1 parent
f4293ba
commit 24b1685
Showing
2 changed files
with
20 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters