Merge pull request #1212 from SergiyYarinovskiy/issue-1210

Fixes Issue #1210: Wrong negative expectation with once

.rubocop.yml

@@ -22,7 +22,7 @@ Metrics/BlockLength:
   Max: 45
 
 Metrics/ModuleLength:
-  Max: 209
+  Max: 210
 
 Metrics/PerceivedComplexity:
   Max: 19

lib/rspec/mocks/message_expectation.rb

@@ -581,6 +581,7 @@ def raise_already_invoked_error_if_necessary(calling_customization)
         end
 
         def set_expected_received_count(relativity, n)
+          raise "`count` is not supported with negative message expectations" if negative?
           @at_least = (relativity == :at_least)
           @at_most  = (relativity == :at_most)
           @exactly  = (relativity == :exactly)

spec/rspec/mocks/at_least_spec.rb

@@ -142,6 +142,14 @@ module Mocks
         expect(@double.do_something).to eq 'bar'
         expect(@double.do_something).to eq 'bar'
       end
+
+      context "when called with negative expectation" do
+        it "raises an error" do
+          expect {
+            expect(@double).not_to receive(:do_something).at_least(:thrice)
+          }.to raise_error(/`count` is not supported with negative message expectations/)
+        end
+      end
     end
   end
 end

spec/rspec/mocks/at_most_spec.rb

@@ -108,6 +108,14 @@ module Mocks
           @double.do_something
         end
       end
+
+      context "when called with negative expectation" do
+        it "raises an error" do
+          expect {
+            expect(@double).not_to receive(:do_something).at_most(:thrice)
+          }.to raise_error(/`count` is not supported with negative message expectations/)
+        end
+      end
     end
   end
 end

spec/rspec/mocks/once_counts_spec.rb

@@ -68,6 +68,14 @@ module Mocks
           }.to fail_with(a_string_including("expected: 1 time", "received: 2 times"))
         end
       end
+
+      context "when called with negative expectation" do
+        it "raises an error" do
+          expect {
+            expect(@double).not_to receive(:do_something).once
+          }.to raise_error(/`count` is not supported with negative message expectations/)
+        end
+      end
     end
   end
 end

spec/rspec/mocks/thrice_counts_spec.rb

@@ -67,6 +67,14 @@ module Mocks
         }.to fail
         reset @double
       end
+
+      context "when called with negative expectation" do
+        it "raises an error" do
+          expect {
+            expect(@double).not_to receive(:do_something).thrice
+          }.to raise_error(/`count` is not supported with negative message expectations/)
+        end
+      end
     end
   end
 end

spec/rspec/mocks/twice_counts_spec.rb

@@ -84,6 +84,14 @@ module Mocks
           }.to fail_with(a_string_including("expected: 2 times", "received: 3 times"))
         end
       end
+
+      context "when called with negative expectation" do
+        it "raises an error" do
+          expect {
+            expect(@double).not_to receive(:do_something).twice
+          }.to raise_error(/`count` is not supported with negative message expectations/)
+        end
+      end
     end
   end
 end